Fixed tableColumnsToJson does not handle "N;"

[Xon]

Affected version

2.1.0 Beta 4

php seralizable columns may have the contents N;, this is caused by passing null to serialize.

The regex tableColumnsToJson uses to find columns with php serialized data will skip these rows.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.1.0 Beta 5).

Change log:

Adjust regex to match serialized values when converting to JSON to `^[abCdiNoOsS]:`

Any changes made as a result of this issue being resolved may not be rolled out here until later.

 

[Mike]

Aww, our bug bot didn't parse Markdown.

I believe that version of the regex should now properly match all of the formats that the PHP source defines, though not including the "R" and "r" types which aren't really applicable here. (There are probably some other additional types that aren't applicable either, though defined in PHP.)

 

[Xon]

@Mike null is serialized to N; not N:, so the regex mentioned in the bugfix might miss it

 

[Mike]

Ahh of course, I'll move this back.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.1.0 Beta 5).

Change log:

(Part 2) Adjust JSON conversion regex to match `^([abCdioOsS]:|N;$)` to catch serialized null correctly. Fix a bug when encoding serialized false to JSON.

Any changes made as a result of this issue being resolved may not be rolled out here until later.