Fixed Table icon missing from dropdown available buttons

Affected version
2.2

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.1).

Change log:
Allow insertTable and xfBbCode commands to be added to custom dropdowns. Prevent paragraphFormat command being added.
There may be a delay before changes are rolled out to the XenForo Community.
 

Chris D

XenForo developer
Staff member
We've relaxed this one, currently, but it could change. Some commands simply do not work inside dropdowns - we have a line of explanation text about that.

Notably, things which are already dropdowns do not work inside dropdowns. These are denoted by a little down arrow. These include the font dropdown, and paragraph format dropdown (which was allowed previously, but shouldn't have been which is now fixed). Dropdowns look like this, so you just can't put dropdowns inside other dropdowns.
1601977221253.png
The other things that sort of look like dropdowns when you click on them including text colour. insert link, insert image and insert table are actually called "popups".

Insert table was being blocked from being added to a dropdown on the basis that it is a popup, but that might have been slightly overzealous and we weren't actually preventing other popups from being added to dropdowns so it was also inconsistent.

For now we've allowed the insert table popup to be added to dropdowns but it has to be said that the behaviour of popups inside dropdowns is not optimal, IMO. They work, but upon clicking on a popup inside a dropdown, the dropdown closes and the popup opens were the dropdown item you clicked on was.

1601977616001.png

This may look odd, therefore, but at this point we'll let admins use their own judgement.

Personally, I wouldn't bother putting popups like insert table inside dropdowns and I'd look at a different approach, but it's up to you.
 

Mr Lucky

Well-known member
I wondered if it was that, hoever then noticed that on here tables are in a dropdown

But also I noticed some other icons, such as paragraph format which itself is a dropdown, it was possible to put in a dropdown, only to find that it didn't work.
 

Chris D

XenForo developer
Staff member
I wondered if it was that, hoever then noticed that on here tables are in a dropdown
They aren't. The insert table button is in the "More options" group section. That's different to a dropdown. It's basically a second toolbar in its own right which buttons overflow to when the group they belong to contains more buttons than their configured limit.

But also I noticed some other icons, such as paragraph format which itself is a dropdown, it was possible to put in a dropdown, only to find that it didn't work.
Indeed. We've fixed that for the next release too.
 
Top