Fixed Submit Reply while still uploading

[MattW]

Have noticed this a couple of times now.

If you copy / paste an image into the editor, and submit while the image is still uploading, the post still be submitted, but the attachment not. The attachment is then available in the next reply.

Would it be possible to disable the Post Reply if an attachment is still uploading?

 

[MattW]

Just testing as well

 

[MattW]

Did it here just now to prove it. Only happens when there is text already in the editor



That image was pasted into the editor, and Post Reply pressed while the image was still being uploaded.

 

[Mike]

First, disabling the post button is a bad idea IMO. It's possible for failures to keep it disabled. So that approach is really a non-starter.

The alternative would be to just do it how we do regular attachments: give you an indication if they're uploading. Unfortunately, that isn't actually simple. The attachment queue event, for example, has some SWFUpload assumptions in it (such as when taking certain actions or just the data in the event). This then follows on to some of the other events.

This would have to be revisited in the future.

 

[Mike]

Oh as a side note, you should see the ajax progress indicator while it's uploading at least.

 

[Rasmus Vind]

A popup box warning you but allowing you to proceed anyway could be a solution.

 

[Mike]

XF2 will now pop up a confirmation if you try to submit a form while an upload is happening. You have the option to confirm this and submit anyway.