XF 1.2 Stop Adsense ads appearing on XF error pages?
- Thread starter CTXMedia
- Start date
I use this:
Obviously there are some templates specific to my site and configuration there.
Code:
<xen:if is="!in_array({$contentTemplate}, array('error', 'search_form', 'search_form_post', 'search_form_profile_post', 'xengallery_search_form_media', 'search_results', 'register_form', 'login', 'error_with_login', 'thread_view', 'cta_overtaking_index'))">Obviously there are some templates specific to my site and configuration there.
CTXMedia
Well-known member
Martok
Well-known member
Martok
Well-known member
It's fine on my site and I've just used Brogan's code. It looks like you've included the code in the ad_above_top_breadcrumb template as the advert doesn't show on the login page but you've not added it to ad_below_bottom_breadcrumb as that is the advert that still shows.
It's just the 404 pages that are still showing adverts.
MattW
Well-known member
I have them on above top breadcrumb, and below bottom breadcrumb. I'm testing the conditional on the top breadcrumb before applying it to the bottom one as well.
It's not displaying when the URL ends in login, but for some reason, after the second attempt, it's showing login/login ?
http://www.z22se.co.uk/login/login
Sportsoutlaw
Active member
Just a word of warning to anybody using adsense, be sure to use this conditional around your ad code. I have had adsense on sites for well over 10 years, and never thought about it, nor had it been an issue.
Yesterday, I received a warning from adsense due to content displaying on an "non content" page. It was an error page for a thread that had been removed.
Thanks @Brogan for putting this together, saved me a ton of headache tonight!
I know this post is super old but cant you just do this
Code:
---extra.css---
.error .banner-728-90 {
display: none;
}
Code:
<div class="banner-728-90">
<script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
<!-- bredcrumb -->
<ins class="adsbygoogle"
style="display:block"
data-ad-client="ca-pub-00000000000"
data-ad-slot="0000000000"
data-ad-format="auto"></ins>
<script>
(adsbygoogle = window.adsbygoogle || []).push({});
</script>
</div>
Seeing this thread popping up inspired us to consider how we can improve this in XF2.
As we have a better system for the management of advertising in XF2, we've added an option which allows you to list templates which globally shouldn't display any advertising.
By default this happens on all error pages (error template) and message only templates (message_page template), though of course you can add your own.
So taking @Brogan's old example literally, you would now just do this in the Appearance option group or, conveniently, below the advertising list in the Admin CP:
(Though bear in mind some of those templates probably have different names now
)
As we have a better system for the management of advertising in XF2, we've added an option which allows you to list templates which globally shouldn't display any advertising.
By default this happens on all error pages (error template) and message only templates (message_page template), though of course you can add your own.
So taking @Brogan's old example literally, you would now just do this in the Appearance option group or, conveniently, below the advertising list in the Admin CP:
(Though bear in mind some of those templates probably have different names now
)
Could someone please help me?
I had:
And replaced it by:
How can I merge these two statements?
Thanks!
I had:
Code:
<xen:if is="{xen:helper ismemberof, $visitor, 1, 84}">And replaced it by:
Code:
<xen:if is="!in_array({$contentTemplate}, array('error', 'search_form', 'search_form_post', 'search_form_profile_post', 'xengallery_search_form_media', 'search_results', 'register_form', 'login', 'error_with_login', 'thread_view', 'cta_overtaking_index'))">How can I merge these two statements?
Thanks!
