spam cleaner error

[jacko]

I tried to use spam cleaner with its default options on an user and I got this:
-----------------
A discussion insert was attempted without the required first message.

1. XenForo_DataWriter_Discussion->_preSave() in XenForo/DataWriter.php at line 1331
2. XenForo_DataWriter->preSave() in XenForo/DataWriter.php at line 1271
3. XenForo_DataWriter->save() in XenForo/Model/InlineMod/Thread.php at line 114
4. XenForo_Model_InlineMod_Thread->deleteThreads() in XenForo/SpamHandler/Thread.php at line 70
5. XenForo_SpamHandler_Thread->cleanUp() in XenForo/Model/SpamCleaner.php at line 29
6. XenForo_Model_SpamCleaner->cleanUp() in XenForo/ControllerPublic/SpamCleaner.php at line 51
7. XenForo_ControllerPublic_SpamCleaner->actionIndex() in XenForo/FrontController.php at line 310
8. XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 132
9. XenForo_FrontController->run() in /home/xxxx/public_html/index.php at line 15

 

[Mike]

That's really, really strange - that error indicates that it's doing an insert, when trying to delete stuff. That should never happen... I'm possibly seeing the code path that it might take, but I'm a little confused as to why. Can you try it again?

 

[Snoozero]

I just had this same error. It looks like it only fails when deleting a user's threads, it works fine when only deleting posts.

Even if I run the cleanup on them a second time, it still throws the same error.

1. XenForo_DataWriter_Discussion->_preSave() in XenForo/DataWriter.php at line 1331
2. XenForo_DataWriter->preSave() in XenForo/DataWriter.php at line 1271
3. XenForo_DataWriter->save() in XenForo/Model/InlineMod/Thread.php at line 114
4. XenForo_Model_InlineMod_Thread->deleteThreads() in XenForo/SpamHandler/Thread.php at line 70
5. XenForo_SpamHandler_Thread->cleanUp() in XenForo/Model/SpamCleaner.php at line 29
6. XenForo_Model_SpamCleaner->cleanUp() in XenForo/ControllerPublic/SpamCleaner.php at line 51
7. XenForo_ControllerPublic_SpamCleaner->actionIndex() in XenForo/FrontController.php at line 310
8. XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 132
9. XenForo_FrontController->run() in /var/www/public/xxx/index.php at line 15
10. require() in /var/www/public/xxx/wrapper.php at line 181

edit: looks like it deleted all their threads as well, but it didn't reset their post count correctly.

 

[Mike]

I've applied a fix for this issue for the next release.