sonnb - Xenforo Trigger Lightbox

sonnb - Xenforo Trigger Lightbox 1.0.10

No permission to download
Hi,

I am either to stupid or too tired, but I do not find the spot for setting image.php on/off .... :cry:

Where can I find this in xenforo ACP?

Thanks in advanc
 
when i click use Resizer for external images, externam images show as broken unless i click em
Code:
http://localhost/image.php?url=http://i.imgur.com/08beUIL.jpg&width=300&height=300
says 404 not found
 
I didn't see a preview of it and it's a great addon - so here's a screenshot from my forum.
210319.png


Also, I have two suggestions that would make this amazing - if you'd add them:
I'm using SSL and when you open the image, it doesn't use the image proxy.. Can you fix this and also, I'm not a fan of it doing this to every image, could you only do it to ones that are too big for the page (like xF usually does).
 
I didn't see a preview of it and it's a great addon - so here's a screenshot from my forum.
210319.png


Also, I have two suggestions that would make this amazing - if you'd add them:
I'm using SSL and when you open the image, it doesn't use the image proxy.. Can you fix this and also, I'm not a fan of it doing this to every image, could you only do it to ones that are too big for the page (like xF usually does).
They are different stories. The XF one is by CSS which can limit by CSS while this one is javascript. It will unable to do in some cases or require extra works in JS to check the size of image.
 
Feature request: When viewing an inserted image that links to an external page (eg, Flickr), the current behavior is that clicking on that image takes you to the external site.

Example:
DSCF1404 by Amin Sabet, on Flickr

I'd like to see it changes so that clicking on an image linked to an external page prompts you to choose between viewing in Lightbox or viewing on external site. This is one of the features my members miss since we removed Tapatalk.
 
Installed and working, really great addon .

A suggestion for the next revision: option to display the top "Click to full image" message on image hover, like regular XF.
 
I've been using this plugin for years, but it looks like there is a small issue with it.

If a user submits an image that isn't hotlinkable, i get errors thrown in the back end.

Code:
Error Info
ErrorException: Fatal Error: Call to a member function thumbnail() on boolean - image.php:45
Generated By: Unknown Account, 17 minutes ago
Stack Trace
#0 [internal function]: XenForo_Application::handleFatalError()
#1 {main}
Request State
array(3) {
  ["url"] => string(128) "https://mysite.com/image.php?url=http://natgeo.petsmart.com/content/img/guinea-pig/guinea-pig-behavior.jpg&width=300&height=300"
  ["_GET"] => array(3) {
    ["url"] => string(73) "http://natgeo.petsmart.com/content/img/guinea-pig/guinea-pig-behavior.jpg"
    ["width"] => string(3) "300"
    ["height"] => string(3) "300"
  }
  ["_POST"] => array(0) {
  }
}

The obvious thing here are that it's saying that line 45 in image.php is erroring out. This line is

PHP:
        {
            $image_gd->thumbnail($max_width, $max_height);
        }

So this line is responsible for (what I assume to be) resizing the image if the max_width exceeds the set limit. Since the image isn't going to embed, it's throwing errors.

The previous code is located within this block.

PHP:
switch ($image_type[2])
{
    case IMAGETYPE_GIF:
    case IMAGETYPE_JPEG:
    case IMAGETYPE_PNG:
        $image_gd = XenForo_Image_Gd::createFromFileDirect($validUrl, $image_type[2]);
      
        if (!$internalLink && $max_width)
        {
            $image_gd->thumbnail($max_width, $max_height);
        }
        else
        {
            $image_gd->thumbnail($image_type[0], $image_type[1]);
        }
      
        $response = new Zend_Controller_Response_Http();
        $response->setHeader('Content-Type', $image_type['mime']);
        $response->sendHeaders();
      
        $image_gd->output($image_type[2]);
        break;
    case IMAGETYPE_BMP:
        $response = new Zend_Controller_Response_Http();
        $response->setHeader('Content-Type', $image_type['mime']);
        $response->sendHeaders();
      
        echo file_get_contents($validUrl);
    default:
        $response = new Zend_Controller_Response_Http();
        $response->setHeader('Content-Type', $imageTypes['png']);
        $response->sendHeaders();
      
        echo file_get_contents(XenForo_Template_Helper_Core::getAvatarUrl(array(), 'l'));
        break;
}

So I guess the best way to sort this out would be to add some sort of check to see if an image will be embed-able. I'm currently not sure of how to do this.

I'm sure I can eventually find some hackey way around this, I was just wondering if anyone else had the same issue? Is there another lightbox solution available?
 
Top Bottom