Fixed SMF Importer doesn't transfer [img] bbcode

[jeffwidman]

@Chris D --sorry to be dumping bug reports on you.

Discovered some IMG BBCode that isn't showing up properly after I did the SMF import. I think it's because it includes width and height codes. I tried a few different variations, like putting the values in quotes, but nothing worked other than completely stripping out the width and height attributes--does Xenforo not support them in IMG tags?

Here's an example:

[img width=400 height=266]http://h.fastcompany.net/multisite_files/fastcompany/imagecache/slideshow_large/slideshow/2014/12/3039678-slide-s-6-star-wars-photos-by-thomas-dagg.jpg[/img]

As soon as I strip out the width and height it works properly.

Not sure if this falls within the scope of the importer, or something that manually should be handled by the admin. It's a fairly standard tag...

 

[Jeremy]

XenForo does not support width and height in IMG.

 

[Chris D]

We'll handle that in the next version of the importer with this:

$string = preg_replace('#\[img.*](.*)\[/img\]#siU', '[IMG]$1[/IMG]', $string);

 

[jeffwidman]

When I stick that in the find and replace, I get:

Server Error

preg_match_all(): Delimiter must not be alphanumeric or backslash

XenForo_Application::handlePhpError()
preg_match_all() in PostReplace/ControllerAdmin/PostReplace.php at line 26
PostReplace_ControllerAdmin_PostReplace->actionReplace() in XenForo/FrontController.php at line 347
XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 134
XenForo_FrontController->run() in /home/nginx/domains/sportsjournalists.com/public/forum/admin.php at line 13

I'm limiting the intial find to posts containing "img",
using the Regex you suggested above for finding:

\[img.*](.*)\[/img\]

As well as the replacement regex:

[IMG]$1[/IMG]

 

[Chris D]

The regex is:

#\[img.*](.*)\[/img\]#siU

 

[jeffwidman]

Thx.

Sorry for missing it--I'd never seen '#' used as a regex metacharacter before... it's not part of the standard set that I learned: http://www.regular-expressions.info/characters.html

 

[Chris D]

All PCRE functions in PHP require the pattern to be enclosed within delimiter characters. See this for reference: http://php.net/manual/en/regexp.reference.delimiters.php