expanserpb
Active member
Removed the Clearsitedata() call from my installation for now
What are the consequences of doing this?Removed the Clearsitedata() call from my installation for now
from Xenforo Core ?Removed the Clearsitedata() call from my installation for now
Yes i want to apply that but How can i clear (pass) the file healt check error on admin cp then?This is beyond annoying... I'm running Chrome 77.0.3865.90 64 bit too. I didn't know what do do other than to remove the offending line, so I did for Chrome, though still run it for non-Chrome browsers (I tested the following on Edge, Firefox, and Chrome).
I edited /src/XF/Controller/Plugin, function logoutVisitor()
and changed:
$this->clearSiteData();
to:
if (!stristr($_SERVER['HTTP_USER_AGENT'], 'Chrome') or stristr($_SERVER['HTTP_USER_AGENT'], 'Edge')) $this->clearSiteData();
(Edge's useragent includes 'Chrome' in it, so I needed to carve that one out too.).
Now Chrome doesn't hang any more At least not until the next XF update.
It is basically easy way but i'm looking the professional way to clear that error. For example, i edit the hashes.json file after edit some files of any add-on and it pass the file health.You just ignore the file health check entry on file as you know you edited it.
This is beyond annoying... I'm running Chrome 77.0.3865.90 64 bit too. I didn't know what do do other than to remove the offending line, so I did for Chrome, though still run it for non-Chrome browsers (I tested the following on Edge, Firefox, and Chrome).
I edited /src/XF/Controller/Plugin, function logoutVisitor()
and changed:
$this->clearSiteData();
to:
if (!stristr($_SERVER['HTTP_USER_AGENT'], 'Chrome') or stristr($_SERVER['HTTP_USER_AGENT'], 'Edge')) $this->clearSiteData();
(Edge's useragent includes 'Chrome' in it, so I needed to carve that one out too.).
Now Chrome doesn't hang any more At least not until the next XF update.
../src/XF/ControllerPlugin/Login.php - around line 257
Standing with your arms crossed waiting for Google Chrome to change doesn't help XF site owners and dealing with the users. Google Chrome will win. Fix it please. Google is not going to change for XF.
You can fix this yourself to fix chrome’s bug, follow the instructions in this post, https://xenforo.com/community/threads/session-does-not-close-with-chrome.167665/page-2#post-1375796
We use essential cookies to make this site work, and optional cookies to enhance your experience.