XF 2.2 server errors - can anyone help?

[Joao Prates]

After following a fellow member suggestion on this thread, I ended up with a working solution (the images are showing up fine) but with lots of server errors being generated on a context I don't fully understand.

Here's an error instance example:




The template changed was message_macros, and the change is seen in the originating thread referenced above.

I'm not clever enough to understand how something that is displaying correctly and generating no errors whatsoever for almost an hour suddenly generates some dozens errors all equal like the one above.

Can any of you guys and gals help me out understand and fix this?
I really like the end result, it is displaying the group image fine, but I never had server errors and I would like to keep it that way.

Thanks

 

[Joao Prates]

It seems all errors being generated relate to one thread where we had one (the only one actually) user we had to ban and delete his account.

I'm getting the idea that his posts now displaying "Deleted member 314" have no $user associated, since the account was deleted.

What's the sintax for testing if $user is null, so that I can proceed with the rest of the code for image display only if $user is not null?

By the way, since this is my first try into xf coding, is there a language reference guide somewhere?

 

[Dragonfruit]

It seems all errors being generated relate to one thread where we had one (the only one actually) user we had to ban and delete his account.

I'm getting the idea that his posts now displaying "Deleted member 314" have no $user associated, since the account was deleted.

What's the sintax for testing if $user is null, so that I can proceed with the rest of the code for image display only if $user is not null?

By the way, since this is my first try into xf coding, is there a language reference guide somewhere?

I did a quick google, and found this:

Conditional Statements for XenForo 2

XF2: Using conditional statements, how do I identify if a page is a Index page (or) What's New page (or) Search Results page ...etc ? 17. How can I show content only at home? Code: Show content...

xenforo.com

<xf:if is="$user AND {{$user.isMemberOf(x)}}">
code here
</xf:if>

Give that syntax a try, it should read as; If the user is a Member AND a member of User Group, then display image.

We use this addon to change post authors:

Change author

Description: Allows changing the author of a post. (Example of Change author link) (Example of Change author overlay) (Example of User group permissions) Features: All phrases start with changeauthor_ for your convenience. User group...

www.xf2addons.com

Just in case you need that in the future.

 

[Joao Prates]

I did a quick google, and found this:

exactly that, well done!

Changed the code and cleaned the logs, let's hope for the best.

Once again thanks a lot for your support @Dragonfruit !

 

[Joao Prates]

Hi all, @Dragonfruit ,

Just to update with a status report that the logs are clean all these hours later, so the solution suggested above worked.

Don't know if this should be considered a bug in XF or not, having a post with no user account whatsoever assigned?

I'll let others decide that. For me the case is closed.

Thanks.

 

[Paul B]

Don't know if this should be considered a bug in XF or not, having a post with no user account whatsoever assigned?

It's not a bug - XF allows for posts from guests and also deleted accounts.

The issue was with the original modification you made, which didn't take those scenarios into account.

 

[Joao Prates]

I really think I should open a new feature request, or however you call it, because allowing for group avatars is such a basic feature and it is missing.
It should IMHO not be necessary for us to write if-then-else code into the templates for such a common functionality.

On our old Community Server some 15 years ago we had this with roles, and the advantage was that anyone could click on the avatar and see the list of all users pertaining to that role.

We found this most useful, and surely (I think) it should be quite easy for the dev team to implement the functionality, am I wrong?

Where (url) do we submit theses requests into?

 

[Paul B]

You can already add an image to user groups.

It's done with the user group banner function and custom CSS.

 

[Joao Prates]

I need to learn CSS then...

You guys must stop assuming we are all programmers... some of us are not, and some are but not on these languages and interfaces

 

[beerForo]

I think he wants users to add their own, as in, their own company logo. No?

 

[Joao Prates]

No, it was not a request to go that far, but that would be awesome, if the trouble/work would be similar from dev, then yes please.

It does pose some concerns in trusting users to upload pictures and choosing their own groups... hummm... nahhh... too tricky, I won't ask for that.