Search Improvements 2.17.7

[Alpha1]

I'm unable to set content type weighting and save this page:



Therefore I most content types do not show up in latest activity or search. I guess I need to disable this addon.

 

[Xon]

I'm unable to set content type weighting and save this page:

Is there any messages or is it just not sticking?

 

[Alpha1]

Its just not sticking.

 

[Xon]

Its just not sticking.

After a false positive, I'm not being able top replicate this issue.

Can you try via this method;
AdminCP => Add-ons => Search Improvements => dropdown => Options
(aka /admin.php?add-ons/SV-SearchImprovements/options )

This way only this add-on options are attempted to be saved incase it is a 3rd party compatibility issue doing something weird

 

[Alpha1]

No dice.
Firefox browser.
Search Improvements 2.17.3
XF2.3.7
PHP 8.3.24
MariaDB10.3.39

 

[Xon]

Can you try disabling all other add-ons except for Search Improvements and then attempt to save that options page?

 

[Digital Doctor]

disabling all other add-ons except for Search Improvements

101 addons and counting...

That's alot of disabling !

 

[Alpha1]

That's alot of disabling !

Disabling is easy, but takes a while. Enabling them one by one takes quite some time to do. Especially with sloooow rebuilds.

 

[MentaL]

101 addons and counting...

That's alot of disabling !

top right

 

[Alpha1]

I disabled all addons except:
Search Improvements
Standard Library
XFES
XFRM
XFMG
Still the same.

Also tried disabling XFES, XFRM, XFMG and still didn't work.

 

[MentaL]

style/cache issue? maybe rebuild style?

 

[Alpha1]

I will try that after I'm done re-enabling everything. Will take a bit...

 

[Xon]

I disabled all addons except:
Search Improvements
Standard Library
XFES
XFRM
XFMG
Still the same.

Also tried disabling XFES, XFRM, XFMG and still didn't work.

I'm wondering if cloudflare (or some web-application-firewall) is interrupting the submit; can you open the network tab of browser tools and try saving and seeing if the post returns any errors?

 

[Alpha1]

I do find this one in the browser console:
Uncaught (in promise) TypeError: NetworkError when attempting to fetch resource.

But that's on pretty much all pages. I've asked CF support for more information on this one.

 

[Xon]

The code which runs when the option value is verified is very simple*, the only way I can think of it is failing is if something is preventing the option entity itself from saving.

*It filters out content types which no longer have a search handler or have a weight value of 1

 

[Alpha1]

We now found out how to save it:
It does not save if the value for the enabled option is 1. (default value)
It does save if the value is not 1.
The + - buttons will turn it into a 4 digit value instead of going from 1 to 2 it will go to 1.001

If this is intended behavior, then it may be a good idea to add a bit of text to the page that explains this.

 

[Xon]

Xon updated Search Improvements with a new update entry:

2.17.4 - Maintenance update

• Adjust defaults for autocomplete boosts to better favor exact matches.
  • Affects non-default "Tag/Username auto-complete search field boosts" option

Read the rest of this update entry...

 

[Deazer]

• [E_WARNING] Undefined array key "keywords"

#0 src/addons/SV/SearchImprovements/XF/Pub/Controller/SearchPatchLast.php(42): XF::handlePhpError(2, '[E_WARNING] Und...', '/var/www/myweb...', 42)
#1 src/addons/SV/SearchImprovements/XF/Pub/Controller/SearchPatchLast.php(112): SV\SearchImprovements\XF\Pub\Controller\SearchPatchLast->svSearchFromQueryData(Array)
#2 src/addons/SV/SearchImprovements/XF/Pub/Controller/Search.php(161): SV\SearchImprovements\XF\Pub\Controller\SearchPatchLast->actionResults(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(362): SV\SearchImprovements\XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#4 src/XF/Mvc/Dispatcher.php(265): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Results', Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\SearchPatchFirst), Object(XF\Mvc\Reply\Reroute))
#5 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\SearchPatchFirst), Object(XF\Mvc\Reply\Reroute))
#6 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#7 src/XF/App.php(2824): XF\Mvc\Dispatcher->run()
#8 src/XF.php(814): XF\App->run()
#9 index.php(23): XF::runApp('XF\\Pub\\App')
#10 {main}

v2.3.8 (Preview)

 

[Xon]

Xon updated Search Improvements with a new update entry:

2.17.5 - Bugfix update

• XF2.3.8 compatibility fix

Read the rest of this update entry...

 

[Deazer]

Xon updated Search Improvements with a new update entry:

2.17.5 - Bugfix update



Read the rest of this update entry...

• [E_WARNING] Undefined array key "search_type"

#0 src/addons/SV/SearchImprovements/XF/Pub/Controller/SearchPatchFirst.php(24): XF::handlePhpError(2, '[E_WARNING] Und...', '/var/www/myweb...', 24)
#1 src/addons/SV/SearchImprovements/XF/Pub/Controller/SearchPatchLast.php(52): SV\SearchImprovements\XF\Pub\Controller\SearchPatchFirst->prepareSearchQuery(Array, NULL)
#2 src/addons/SV/SearchImprovements/XF/Pub/Controller/SearchPatchLast.php(115): SV\SearchImprovements\XF\Pub\Controller\SearchPatchLast->svSearchFromQueryData(Array)
#3 src/addons/SV/SearchImprovements/XF/Pub/Controller/Search.php(161): SV\SearchImprovements\XF\Pub\Controller\SearchPatchLast->actionResults(Object(XF\Mvc\ParameterBag))
#4 src/XF/Mvc/Dispatcher.php(362): SV\SearchImprovements\XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#5 src/XF/Mvc/Dispatcher.php(265): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Results', Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\SearchPatchFirst), Object(XF\Mvc\Reply\Reroute))
#6 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\SearchPatchFirst), Object(XF\Mvc\Reply\Reroute))
#7 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#8 src/XF/App.php(2824): XF\Mvc\Dispatcher->run()
#9 src/XF.php(814): XF\App->run()
#10 index.php(23): XF::runApp('XF\\Pub\\App')
#11 {main}

There are still warnings left anyway