Not a bug RSS feed error - Error: Call to a member function getTimeStamp

[Neal]

Affected version

2.0.0 Beta 6

I get the following error when trying to run RSS Feed Importer for the following URL - https://www.mi5.gov.uk/UKThreatLevel/UKThreatLevel.xml

Error: Call to a member function getTimeStamp() on null src/XF/Service/Feed/Reader.php:127
Generated by: Me 17 October 2017 at 20:27

Stack trace

#0 src/XF/Service/Feed/Reader.php(97): XF\Service\Feed\Reader->getFeedEntries()
#1 src/XF/Service/Feed/Feeder.php(24): XF\Service\Feed\Reader->getFeedData()
#2 src/XF/Admin/Controller/Feed.php(208): XF\Service\Feed\Feeder->setupImport(Object(XF\Entity\Feed), true)
#3 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\Feed->actionImport(Object(XF\Mvc\ParameterBag))
#4 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Feed', 'Import', 'html', Object(XF\Mvc\ParameterBag), 'rssFeedImporter', Object(XF\Admin\Controller\Feed), NULL)
#5 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(1831): XF\Mvc\Dispatcher->run()
#7 src/XF.php(328): XF\App->run()
#8 admin.php(13): XF::runApp('XF\\Admin\\App')
#9 {main}

Request state

array(4) {
  ["url"] => string(38) "/admin.php?feeds/threat-level.5/import"
  ["referrer"] => string(44) "https://something.here/admin.php?feeds/"
  ["_GET"] => array(1) {
    ["feeds/threat-level_5/import"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}

 

[Chris D]

This is actually not really a bug - the feed itself doesn't meet the necessary specs. Notably the entry dates:

<pubDate>Sunday, September 17, 2017 - 15:09</pubDate>

That should be an RFC-822 formatted date similar to what they actually have as their feed date:

<lastBuildDate>Sun, 17 Sep 2017 15:09:52 +0100</lastBuildDate>

However, we have added some code to handle invalid dates better. I'd recommend providing feedback to the website which provides the feed, if possible. (Though with it being MI5, maybe they already know we're having this conversation ).