Design issue Redirect error with page

[Cao]

When I go to:

http://xenforo.com/community/threads/welcome-to-xf-1-3-assorted-improvements.67121/?page=2
or
http://xenforo.com/community/threads/welcome-to-xf-1-3-assorted-improvements.67121?page=2

System will redirect to:
http://xenforo.com/community/threads/welcome-to-xf-1-3-assorted-improvements.67121/page-2?page=2

 

[Amaury]

I cannot confirm this on Mozilla Firefox 27.0. I don't even have the question marks seen above.
http://xenforo.com/community/threads/welcome-to-xf-1-3-assorted-improvements.67121/page-2
http://xenforo.com/community/threads/welcome-to-xf-1-3-assorted-improvements.67121/page-2

 

[Paul B]

I believe the OP is manually adding ?page=2 to the URL.

 

[Mike]

This is more or less a design issue with the redirects. We can't remove query string params when redirecting as they generally won't be handled by the route itself. Here's a situation where the param can theoretically be seen both as part of the route itself and the query string.

In general, this URL should never be generated. If it is, that would be a bug, but I don't think it's possible with our URL generation options.

 

[Cao]

This is more or less a design issue with the redirects. We can't remove query string params when redirecting as they generally won't be handled by the route itself. Here's a situation where the param can theoretically be seen both as part of the route itself and the query string.

In general, this URL should never be generated. If it is, that would be a bug, but I don't think it's possible with our URL generation options.

Yes, I got it when redirect old url when convert from vBulletin.
I must to add this code to index.php to fix it.

if(preg_match('#^/threads/(?<slug>[a-z0-9\-]+)\.(?P<id>[0-9]+)/page-(?P<page>[0-9]+)\?page\=(?P<page2>[0-9]+)$#i',$_SERVER['REQUEST_URI'],$arr))
{
    header("Location: /threads/{$arr['slug']}.{$arr['id']}/page-{$arr['page']}",1,301);
    exit;
}