1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Not a Bug RC1: Tweet button does not change even if it is translated

Discussion in 'Resolved Bug Reports' started by soloarquitectura, Jan 20, 2011.

  1. soloarquitectura

    soloarquitectura Active Member

    In Spanish "Tweet" = "Twittear".

    tweet.jpg
     
  2. Brogan

    Brogan XenForo Moderator Staff Member

    That's an iFrame so it can't be translated.

    It would need language locale integration to display in the forum language.
     
    soloarquitectura likes this.
  3. Vincent

    Vincent Well-Known Member

    That button is taken from Twitter. Not from xenForo.
    There also is no way (yet) to take the language from twitter there. (I am not sure, but I think)
     
  4. ibnesayeed

    ibnesayeed Well-Known Member

    If language/locale is passed in the parameters of iFrame then we might possibly get translations provided by Twitter, same might be applied on Facebook like button.
     
  5. soloarquitectura

    soloarquitectura Active Member

    And the phrase "tweet"?

    tweet_phrase.jpg
     
  6. soloarquitectura

    soloarquitectura Active Member

  7. ibnesayeed

    ibnesayeed Well-Known Member

    This phrase is probably used somewhere else. May be in admin CP.
     
  8. Vincent

    Vincent Well-Known Member

    Yes, but I don't think that's possible (yet).

    If you do that, nothing happens.
     
  9. Vincent

    Vincent Well-Known Member

  10. ibnesayeed

    ibnesayeed Well-Known Member

    data-lang is the attribute to pass the locale. And luckily they have Spanish. :)

    Consider modifying the template. :)
     
    soloarquitectura likes this.
  11. Shadab

    Shadab Well-Known Member

    That phrase is shown if you have javascript disabled:

    tweet_phrase.png
     
    soloarquitectura likes this.
  12. soloarquitectura

    soloarquitectura Active Member

    Vincent likes this.
  13. Vincent

    Vincent Well-Known Member

    Had just found that out too :)
    Cool eh ;)

    EDIT: Now it's the devs that gotta make it ML, because with facebook it is translated via fb_channel.php
     
  14. soloarquitectura

    soloarquitectura Active Member

    Not a bug. But a good suggestion for RC2 [​IMG]
     
  15. Vincent

    Vincent Well-Known Member

    Go suggest this ;)
     
  16. Mikey

    Mikey Well-Known Member

    Or, they could simply add in a box for "language" like so;
    twitlang.png
    (demo image only)
     
  17. ibnesayeed

    ibnesayeed Well-Known Member

    This is not the preferred way as it will lock it down to one language. There are multi-lingual forums with dynamic language selection option (and yes, XF supports it). :)
     
  18. Vincent

    Vincent Well-Known Member

    I don't think it is that difficult for the DEVS to create a simple {locale} thingee to use in the code ;)
     

Share This Page