1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Partial Fix Quoting a Facebook embed video

Discussion in 'Resolved Bug Reports' started by Moshe1010, Sep 10, 2015.

  1. Moshe1010

    Moshe1010 Well-Known Member

  2. Brogan

    Brogan XenForo Moderator Staff Member

    Looks like it's due to the max height for the iframe.

    upload_2015-9-10_9-33-7.png
     
  3. Mike

    Mike XenForo Developer Staff Member

    Which is something we add. We may need to identify some additional FB classes as well.
     
  4. Mike

    Mike XenForo Developer Staff Member

    I've fixed this now. I've also switched the default embed system back to video style (https://developers.facebook.com/docs/plugins/embedded-video-player); I don't think that actually existed when we had to switch to what is the current embed style a little while ago. This is generally more consistent with other embeds and handles the resizing more gracefully.
     
    Moshe1010 and Chris D like this.
  5. Moshe1010

    Moshe1010 Well-Known Member

    It came back for some reason. Half of the video is hidden in the quote.
     
  6. Mike

    Mike XenForo Developer Staff Member

    The video in the test thread seems to be displaying properly for me.
     
  7. Brogan

    Brogan XenForo Moderator Staff Member

    It's not displaying correctly for me on my tablet.

    It is on desktop.
     
  8. Moshe1010

    Moshe1010 Well-Known Member

    Yeah seems like a mobile/tablet issue only.
     
  9. Moshe1010

    Moshe1010 Well-Known Member

  10. Chris D

    Chris D XenForo Developer Staff Member

    We'll take another look at this.
     
  11. Mike

    Mike XenForo Developer Staff Member

    I think we're going to have to call this a service issue. The height differences are coming from the FB JS, so we don't really have any ability to override them. They are brought directly into the CSS as specific values so we can't really react to them very much.
     

Share This Page