1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Quotation marks hardcoded, another inconsistency

Discussion in 'Resolved Bug Reports' started by Luxus, May 30, 2013.

  1. Luxus

    Luxus Well-Known Member

    XenForo uses english 'quotation marks' a lot. On a lot of places like for example the Reported Items list the quotation marks are phrased, providing you with the convenience of replacing them with non-english quotation marks like „…“ for example.

    That being said, the quotation marks from the following tooltip are hardcoded:


    As shown in the html
    title="{xen:phrase select_thread}: '{$thread.title}'" /></xen:if>
    Alien and Shelley like this.
  2. Vincent

    Vincent Well-Known Member

    Just out of curiosity, what else would be used?
  3. Brogan

    Brogan XenForo Moderator Staff Member

    I presume he wants them changed to a phrase.

    title="{xen:phrase select_thread}{xen:phrase colon} {xen:phrase inverted_comma}{$thread.title}{xen:phrase inverted_comma}" /></xen:if>
    Vincent likes this.
  4. Mike

    Mike XenForo Developer Staff Member

    In this situation, the quotes don't make sense so should be removed. We really only use it to offset within a sentence structure.
  5. Luxus

    Luxus Well-Known Member

    Eh, no that's overkill. Much simpler is to make the variable {$thread.title} work inside the phrase "select_thread". The same that has been done for example in the news_feed_post_insert phrase:

    {username} replied to the thread {threadTitle}.


    I have no problem with that.
  6. Mike

    Mike XenForo Developer Staff Member

    Quotes removed.
    Luxus likes this.

Share This Page