• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Quotation marks hardcoded, another inconsistency

Luxus

Well-known member
#1
XenForo uses english 'quotation marks' a lot. On a lot of places like for example the Reported Items list the quotation marks are phrased, providing you with the convenience of replacing them with non-english quotation marks like „…“ for example.

That being said, the quotation marks from the following tooltip are hardcoded:

quotationmark.png

As shown in the html
Code:
title="{xen:phrase select_thread}: '{$thread.title}'" /></xen:if>
 

Brogan

XenForo moderator
Staff member
#3
I presume he wants them changed to a phrase.

Code:
title="{xen:phrase select_thread}{xen:phrase colon} {xen:phrase inverted_comma}{$thread.title}{xen:phrase inverted_comma}" /></xen:if>
 

Mike

XenForo developer
Staff member
#4
In this situation, the quotes don't make sense so should be removed. We really only use it to offset within a sentence structure.
 

Luxus

Well-known member
#5
I presume he wants them changed to a phrase.

Code:
title="{xen:phrase select_thread}{xen:phrase colon} {xen:phrase inverted_comma}{$thread.title}{xen:phrase inverted_comma}" /></xen:if>
Eh, no that's overkill. Much simpler is to make the variable {$thread.title} work inside the phrase "select_thread". The same that has been done for example in the news_feed_post_insert phrase:

{username} replied to the thread {threadTitle}.

Edit:

In this situation, the quotes don't make sense so should be removed. We really only use it to offset within a sentence structure.
I have no problem with that.