Fixed public:push_post_reaction missing posterParams

[digitalpoint]

Affected version

2.2.13

The x_reacted_to_your_post_in_the_thread_y phrase as a replacement variable, posterParams. posterParams is used properly in public:alert_post_reaction and public:reaction_item_post, but it's missing in public:push_post_reaction.

This causes the string sent to the Pusher to be: someUser reacted to <a {posterParams}>your post</a> in the ThreadTitle with Like. In the end, it ends up not being noticeable for Web Push because all HTML entities (including malformed ones) are stripped out with strip_tags().

However... if you are working with a "push provider" that does support HTML (Telegram, Slack, Discord, etc.), you end up with a mucked push message because {posterParams} is a literal used in the push message.

 

[digitalpoint]

Just here to say it's still terribly annoying.

ErrorException: 400: Bad Request: can't parse entities: Expected equal sign in declaration of an attribute of the tag "a" at byte offset 15

...because the "HTML" is this:

someone reacted to <a {posterParams}>your post</a>

 

[avalanch]

Well, 2.2.14 should be released today, let's see if that gets it fixed up.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.14).

Change log:

Pass `posterParams` in the post reaction push template

There may be a delay before changes are rolled out to the XenForo Community.