Fixed JS menu positioning fails if .menu-arrow element is missing

[willl]

Affected version

XF 2.3 Beta 3

With the refactored JS, there is one issue I've discovered; getHorizontalPosition will error out at menuArrow.style.top = '' if the menu being loaded doesn't contain an element with .menu-arrow; In XF 2.2 using jQuery it's just do a silent graceful fail on setting CSS and continue on, but without jQuery no error handling is in place for null values, so the function itself fails and it doesn't complete the positioning of the rendered menu.

Adding an element at the top of the rendered menu container with the menu-arrow class works as a fix, however, but ideally it would continue to handle null values in this case as before.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.0 Beta 6).

Change log:

Fix an issue computing menu positions when menu does not have an arrow

There may be a delay before changes are rolled out to the XenForo Community.