1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

XF 1.5 Problem with digidip links (affiliation)

Discussion in 'Troubleshooting and Problems' started by marremp2, Feb 16, 2016.

  1. marremp2

    marremp2 Member

    I encounter a problem with the Digidip platform (automatic links conversion for affiliation tracking) : if a user makes a simple click on a link, their javascript does not work and clicks are not tracked. Their script only works on my forum in the case the user opens the link in a new window, which almost never happens.

    I read this thread https://xenforo.com/community/threads/link-proxies-significantly-affects-skimlinks.70857
    and I think I understand that it may be due to the new security check that is made on external links and prevents their script to be activated (only on simple click ??).
    I tried to activate the links proxy (solution which was apparently efficient for Skimlinks) but the problem is still there :(

    Is there an other solution ?
    Many thanks for your help !
     
  2. Mike

    Mike XenForo Developer Staff Member

    This is likely down to the implementation of whatever service (Digidip, Skimlinks, etc) and how they listen for link clicks. The situation has moved on from that link proxy related thread; the link proxy is implemented differently now.

    However, we are now using a method to prevent "reverse tabnabbing" which can interfere if other services want to listen for clicks. Reverse tabnabbing would be considered a security issue (in the vein of social engineering rather than anything explicit), so in 1.5.6, I've now added a config.php option to disable our tabnabbing workaround so that if you integrate with a service that also listens to link clicks, you can allow that to take priority. This is something you'll need to explicitly choose to disable in config.php though (once the next release is made).
     
  3. marremp2

    marremp2 Member

    Hello Mike,
    Thanks a lot for your answer, that is a very good news (y). Do you already have a date for this next release ?
     
  4. Mike

    Mike XenForo Developer Staff Member

    This has now been released (it's the tabnabbing option mentioned for config.php).
     
    Rudy likes this.
  5. marremp2

    marremp2 Member

    Great ;)
    I did the upgrade.

    So is it the right syntax for config.php to disable the reverse tabnabbing ?
    Code:
    $config['enableReverseTabnabbingProtection'] = false;
    Because I don't see any changes yet.
     
  6. Mike

    Mike XenForo Developer Staff Member

    That's correct. I checked the URL in your customer area and it's not loading for me (is that the correct URL?) so I can't verify anything.
     
  7. marremp2

    marremp2 Member

    Yes it is correct, but I did the upgrade on our test site.
    I send it to you by pm.
     
  8. marremp2

    marremp2 Member

    The problem was that I forgot to check outdated templates after upgrades...
    Thank you Mike, my links are now correctly modified by digidip.
     
  9. Rudy

    Rudy Well-Known Member

    As I mentioned in my other thread, I noticed a dropoff in revenues since upgrading some forums a couple of weeks ago. Sure enough, I checked my clickthroughs and they had dropped substantially on all of them. One of my affiliates is Viglink, and I use a couple of others, so I would urge anyone who uses these types of monetization services to add this new value to config.php pronto.
     
  10. Rudy

    Rudy Well-Known Member

    Question for @Mike or anyone else: would having this feature enabled affect all Viglink affiliate links, or might it affect some of them and not others? They all use the same script. But, I just wondered if it was reliant on how a user might be visiting, in which browser, which forum areas they may be visiting, etc. My gut instinct tells me that it would affect all links, and not just some.
     
  11. Mike

    Mike XenForo Developer Staff Member

    It would affect all links.
     
    Rudy likes this.
  12. Rudy

    Rudy Well-Known Member

    I've just confirmed it with Viglink: this change did not affect our normal links (which are only modified), but it did affect the link Insert feature. Once I added the new directive to config.php on my various forums, Insert began working properly again.
     

Share This Page