Lack of interest Preserve EXIF info in attachments (ImageMagick)

[Barry13]

Hello,

When Xenforo calls ImageMagick (PECL version, fwiw), it calls the 'thumbnailImage' function instead of resizeImage (or adaptiveResizeImage).
(resizeImage is only used by Xenforo for Scaling Up)

This can be seen in the php file
\upload\library\XenForo\Image\ImageMagick\Pecl.php:

foreach ($this->_image AS $frame)
{
   if ($scaleUp)
   {
      $frame->resizeImage($width, $height, Imagick::FILTER_QUADRATIC, .5, true);
   }
   else if ($oldImagick)
   {
      $frame->thumbnailImage($width, $height, true);
   }
   else
   {
      $frame->thumbnailImage($width, $height, true, true);
   }
   $frame->setImagePage($width, $height, 0, 0);
}

I believe this would be the correct change:

foreach ($this->_image AS $frame)
{
   if ($scaleUp)
   {
       $frame->resizeImage($width, $height, Imagick::FILTER_QUADRATIC, .5, true);
   }
   else if ($oldImagick)
   {
       $frame->resizeImage($width, $height, Imagick::FILTER_QUADRATIC, .5, true);  // keep EXIF
   }
   else
   {
       $frame->adaptiveResizeImage($width, $height, true);   // higher-quality scaling + EXIF retained
   }
   $frame->setImagePage($width, $height, 0, 0);
}

And make sure ImageMagick version >= 6.2.9 is installed.


references:
https://php.net/manual/en/imagick.adaptiveresizeimage.php (req. ImageMagick version >= 6.2.9)
PHP: Imagick::resizeImage - Manual

You should not use the thumbnailImage image method if you want to preserve exif data... You should use the method resizeImage instead.
ImageMagick Preserve Exif Data

Thank you,
Barry

 

[HWS]

Would be great if the edited file could be included in core so that Xenforo doesn't strip EXIF on image resize. Also, the edited file does a higher quality image resize!

Most people don't want to have EXIF data in uploaded photos! It is a huge security problem if location data remains in uploaded files.

 

[snoopy5]

For easy upload...

Is this still working on XF 2.2.13?

 

[snoopy5]

Most people don't want to have EXIF data in uploaded photos! It is a huge security problem if location data remains in uploaded files.

I think each admin should have the option to decide this for himself and the needs of his forum.

 

[HWS]

I think each admin should have the option to decide this for himself and the needs of his forum.

But default should be disabled (removal of location data).