Won't fix PHPDoc issue

xfrocks

Well-known member
This is a cosmetic issue:

PHP:
abstract class XenForo_Image_Abstract
{
/**
    * Crops the current image.
    *
    * @param $x Crop start x position
    * @param $y Crop start y position
    * @param $width Crop width
    * @param $height Crop height
    */
    abstract public function crop($x, $y, $width, $height);
}

The PHPDoc should have param type before param name like below:

Code:
@param int $x Crop start x position
 
I believe that, historically at least, the type was optional. This isn't generally something we'll search for but it may be changed if work is being done in an area.
 
IIRC the variable name is optional. I could be wrong though.

Just bumped into this today after some inspection run, hope it will be updated at some point.
 
Top Bottom