1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Won't Fix PHPDoc issue

Discussion in 'Resolved Bug Reports' started by xfrocks, Nov 22, 2014.

  1. xfrocks

    xfrocks Well-Known Member

    This is a cosmetic issue:

    PHP:
    abstract class XenForo_Image_Abstract
    {
    /**
        * Crops the current image.
        *
        * @param $x Crop start x position
        * @param $y Crop start y position
        * @param $width Crop width
        * @param $height Crop height
        */
        
    abstract public function crop($x$y$width$height);
    }
    The PHPDoc should have param type before param name like below:

    Code:
    @param int $x Crop start x position
     
  2. Mike

    Mike XenForo Developer Staff Member

    I believe that, historically at least, the type was optional. This isn't generally something we'll search for but it may be changed if work is being done in an area.
     
  3. xfrocks

    xfrocks Well-Known Member

    IIRC the variable name is optional. I could be wrong though.

    Just bumped into this today after some inspection run, hope it will be updated at some point.
     

Share This Page