Fixed PHP 8.3 compatibility patch

[Forsaken]

I find it crazy only about 50% of customers run PHP8. That was released 3.5 years ago

Compatibility issues (a lot of extensions got deprecated and no longer are supported on 8.0), or shared hosting that still defaults to 7.4.

 

[duderuud]

Yeah I get that. But the funny part is, the internet is (perceived to be) on the forefront of bleeding edge tech...while, in the same time, the underlying engine is really really old.

Never understood that.

 

[avalanch]

In november we'll have php 8.4 available.

PHP 8.4: What's New and Changed

PHP 8.4: What's new and changed. PHP 8.4 is the active development branch and the current target for new feature and major changes and new [RFCs](%base%/rfcs). Scheduled for general availability on 2024.

php.watch

 

[RobinHood]

 

[Kirby]

Compatibility issues (a lot of extensions got deprecated and no longer are supported on 8.0), or shared hosting that still defaults to 7.4.

... and the fact that XenForo < 2.2.15 told admins that the PHP version is "recommended" if it's > 7.2, so many XenForo admins might not have been aware that they are running (severely) outdated PHP versions and thus do not upgrade even though it might be as easy as changing some options in their hosting account settings / server control panel.

But luckily this has been addressed now

 

[Chris D]

No, i mean the member that triggered the warning... does JohnQMember see it as a page fault while browsing the site, or is it just logged in ACP?

I don’t think you’ve said exactly what error you received so difficult to say but recently a lot of logs generated by newer PHP versions have been deprecation notices which are only logged in debug mode.

 

[Chris D]

This will be formally announced at some point but currently the plan is that XF 3.0 will require a minimum of PHP 8.0.

 

[briansol]

ErrorException: Template error: [E_WARNING] Increment on type bool has no effect, this will change in the next major version of PHP src/XF/BbCode/Renderer/Html.php:296

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.0 Beta 6).

Change log:

Improve PHP 8.3 compatibility.

There may be a delay before changes are rolled out to the XenForo Community.

 

[Chris D]

ErrorException: Template error: [E_WARNING] Increment on type bool has no effect, this will change in the next major version of PHP src/XF/BbCode/Renderer/Html.php:296

This was one of the fixed issues in the patch os all sorted.

 

[Chris D]

We'd already caught the Templater change but otherwise thanks @PaulB.

This has been backported to XF 2.2.16 too.

 

[Sadiq6210]

I am receiving more than 600 errors similar to this:

• ErrorException: Template error: [E_WARNING] Increment on type bool has no effect, this will change in the next major version of PHP
• src/XF/BbCode/Renderer/Html.php:296

As 2.3 may take time, is there a temporary fix/patch for 2.2.15 to stop this error? @Chris D

 

[briansol]

It's attached to the first post. make the change the templater.php

 

[MySiteGuy]

Yeah I get that. But the funny part is, the internet is (perceived to be) on the forefront of bleeding edge tech...while, in the same time, the underlying engine is really really old.

Never understood that.

Companies tend to prefer stability over bleeding edge, especially since you don't know which bleeding edge technology is going to win out for the long run.

The life cycle up to PHP 5.6 was much better, with a longer span before EOL of security updates. There's a reason so many companies opt for the stability of Redhat and it's derivatives (Oracle Linux). Redhat's 10 year lifespan is very compelling, and if you get paid support it's extended to 15 years.

The short 3-year support cycles since PHP 7.0 is insane.

 

[Masetrix]

The life cycle up to PHP 5.6 was much better, with a longer span before EOL of security updates. There's a reason so many companies opt for the stability of Redhat and it's derivatives (Oracle Linux). Redhat's 10 year lifespan is very compelling, and if you get paid support it's extended to 15 years.

Yes, unfortunately this kind of immature banana software (php >7.x) is becoming more and more widespread and users are left behind.
Companies should have to keep security stable as long as the respective software is used.

 

[tpmedia]

I just went up to PHP 8.3 and am now seeing this error. I seem to recall that Xenforo complains if I just edit a PHP file, is there an "official" way of implementing @PaulB 's change?

 

[bzcomputers]

I just went up to PHP 8.3 and am now seeing this error. I seem to recall that Xenforo complains if I just edit a PHP file, is there an "official" way of implementing @PaulB 's change?

I believe you will see the release of XenForo 2.2.16 this week (maybe next), which has the full PHP 8.3 patch incorporated. If you can wait.

Otherwise, you can make the edit yourself now and deal with slight annoyance of XenForo warning you of the edited file until 2.2.16 is released.

 

[Yenxji]

Thank you @PaulB for shared PHP 8.3 fix!

 

[day_tona2]

Do we need to use this fix or is the current version working on 8.2, 8.3?

 

[bzcomputers]

Do we need to use this fix or is the current version working on 8.2, 8.3?

Not needed in 2.2.16+ or 2.3 RC2+.