Fixed PHP 8.3 compatibility patch

[PaulB]

Affected version

2.2.13

This is just a small patch for PHP 8.3 compatibility issues that we've encountered so far.

Notably, XF\BbCode\Renderer\Html attempts to increment a bool in a couple places, a stopSmilies and stopBreakConversion can be either bools or ints. It's not clear to me why they would ever need to be incremented; as far as I can tell, they're never decremented, and those values are never checked. This is probably a bug. Prior versions of PHP would silently refuse to increment bools anyway, so the only incompatibility here is that PHP 8.3 emits a proper warning. The patch preserves the existing behavior, but this is probably unnecessary.

The only other change accounts for a slight change to the phrasing of a deprecation notice that XenForo ignores. XenForo's str_contains test no longer works correctly in PHP 8.3 due to the change in phrasing.

 

[ISPr_Winter]

Thanks for this, Paul. Stopped all the annoying warnings/errors hitting the logs during our PHP 8.3 testing. Hopefully they'll add this to the next 2.2.14 release, as well as 2.3.

 

[duderuud]

8.2 would be the version supported in 2.3

 

[bzcomputers]

8.2 would be the version supported in 2.3

Nope 8.3

Thread 'General 2.3 discussion'

Sep 20, 2023

This thread is for all general discussion related to 2.3.

If you've spotted something in an HYS other than the subject matter you can discuss it here.

Or anything else related to 2.3 in general.

This thread will be kept on topic so any feedback related to development delays, asking for release dates, etc. should be posted in the other thread: https://xenforo.com/community/threads/any-sort-of-roadmap-for-xenforo-2-3.201027/

Now, what Easter eggs have you spotted?


Release Schedule

There are no fixed dates but the release schedule will look something like this.

• 2.3...

• Paul B
• Replies: 242
• Forum: Other XenForo discussions and feedback

• 

https://xenforo.com/community/threads/general-2-3-discussion.216667/page-3#post-1648445

...annoying direct links to post don't seem to work correctly

 

[duderuud]

My bad, I found this:

XF 2.2 Post in thread '2.2.13 PHP'

Jan 10, 2024

8.2 probably works fine. But we aren't going to declare it as being fully supported until XenForo 2.3.

While operationally you shouldn't encounter any issues, your server error log will get flooded with E_DEPRECATED notices if you're using XenForo 2.2 and PHP 8.2 or above with debug/development mode enabled.

These can be safely ignored, though that can be clearly somewhat alarming. There is a similar issue with PHP 8.1 as well, but that's on a much smaller scale.

• Chris D

• 

 

[Andy.N]

I updated to PHP 8.3.2 yesterday and got flooded with these warning errors. Rolled back to 8.2.15 and all is fine.
Given this, I think it's better to wait for 2.3 release and upgrade PHP again.

 

[Dkf]

You have the recommended PHP version.
PHP version 8.3.2

+ XF 2.2.13

All ok
Thank You!

 

[Dkf]

This is just a small patch for PHP 8.3 compatibility issues that we've encountered so far.

Notably, XF\BbCode\Renderer\Html attempts to increment a bool in a couple places, a stopSmilies and stopBreakConversion can be either bools or ints. It's not clear to me why they would ever need to be incremented; as far as I can tell, they're never decremented, and those values are never checked. This is probably a bug. Prior versions of PHP would silently refuse to increment bools anyway, so the only incompatibility here is that PHP 8.3 emits a proper warning. The patch preserves the existing behavior, but this is probably unnecessary.

The only other change accounts for a slight change to the phrasing of a deprecation notice that XenForo ignores. XenForo's str_contains test no longer works correctly in PHP 8.3 due to the change in phrasing.

If you enable the mode
$config['development']['enabled'] = true;

then errors will appear in the forum logs.

 

[Ozzy47]

Best option is to not run PHP 8.3 until it is officially supported by XF.

 

[Mendalla]

My shared hosting hasn't installed 8.3 yet so I'm kind of stuck at 8.2 for now anyway. Hopefully by the time 8.3 becomes the recommended version, they will have it.

 

[Donske]

I am not an expert in PHP, however, I had to come from 7.4 (as listed in my xenforo ACP). Using my cPanel, 8.1.27 is as high as my forum will allow. If I go one more step up to 8.2, I get a 40x page. I could not remember the exact error, as I wanted to get it all back online. I went back to 8.1.27 and it was restored.

However, I do have a question. in my WHM (using AlmaLinux), in the php MultiPHP Manager, I have two tabs "System Settings" and "User Domain Settings". The User Domain Settings has my forum at 8.1 - but the System Settings (server) still has 7.4.

In the Alma Terminal, I ran "convert - version", I got this:
ImageMagick 6.9.12-93 Q16 x86_64 17898

So, does this mean I have conflicts between cPanel 8.1 and WHM (alma) values 7.4, and then this ImageMagick 6.9.12-93. Therefore, maybe I should do a Graceful Reboot of my Alma?

Thank you to anyone in advance

kindly
Donnie

 

[bzcomputers]

I do have a question. in my WHM (using AlmaLinux), in the php MultiPHP Manager, I have two tabs "System Settings" and "User Domain Settings". The User Domain Settings has my forum at 8.1 - but the System Settings (server) still has 7.4.

The "System Settings" PHP Version is what is used by default for new cPanel accounts. What is actually currently being applied to your domain is what you see under "User Domain Settings".

From what you wrote, there are no conflicts in your settings. That being said there is likely no reason to keep your "System Settings" PHP Version on a version lower than the latest actively supported PHP version, which is currently PHP 8.2. Changing your "System Settings" PHP Version to 8.2 means any new account you create will by default be set to PHP 8.2. This will not affect your XenForo install because your "User Domain Setting" PHP Version is what will still be applied to all your existing individual domains.

P.S. If you are running XenForo 2.2.15 you should not have a problem running PHP 8.2.x. Disable your add-ons and check if the issue still remains. If it doesn't re-enable one-by-to find the add-on(s) with the issue(s).

 

[Donske]

Thank you bzcomputers - will do !

 

[Donske]

I disabled all of my Addons - and no-go. Not sure whats next. I don't think rebuilding them or rebuilding the cache would have anything to do with this.

 

[PaulB]

As of XenForo 2.2.15, the first issue addressed by the patch file above has not been fixed, but the second issue has been fixed.

 

[briansol]

Do users see this issue? Got my first one in the admin log today. been on 8.3 for a few weeks now so i'm surprised it's the first one.

 

[eva2000]

Do users see this issue? Got my first one in the admin log today. been on 8.3 for a few weeks now so i'm surprised it's the first one.

I'm pretty sure the number of users running PHP 8.3 might be small right now

 

[Paul B]

3% of self hosted installations which report back to us.

 

[briansol]

No, i mean the member that triggered the warning... does JohnQMember see it as a page fault while browsing the site, or is it just logged in ACP?

 

[duderuud]

I find it crazy only about 50% of customers run PHP8. That was released 3.5 years ago