XF 1.4 Permalink showing full thread url, not post url

[AtemusVdq]

Recently I noticed that the permalink for posts inside of a thread are redirecting to the full thread title instead of the direct post url, although conversations permalinks work just fine. Any idea why the post permalink gives me only the thread url instead?

 

[Mike]

Can you give an example? The permalinks are always links within a thread.

 

[AtemusVdq]

Sure, lets take your post #2 as an example. Permalink is https://xenforo.com/community/threa...-thread-url-not-post-url.124388/#post-1120998
However, all my posts permalinks are https://xenforo.com/community/threads/permalink-showing-full-thread-url-not-post-url.124388/ (the #post-xxxxx number part is missing)

 

[Mike]

I could really only guess that this is add-on related.

 

[AtemusVdq]

Guess I'll have to disable them one by one to check, thanks for the fast answer.

 

[AtemusVdq]

I could really only guess that this is add-on related.

Been a bit busy lately, however I did tried to disable all addons and I still get the same. When I get an alert (like, quote) the permlink works fine and it points me to the exact post however the permalinks of all posts inside of the thread are simply not working and I get the full thread link instead, no #post number extension.

 

[Paul B]

What about in a completely default style?

 

[AtemusVdq]

Haven't tried that yet, however I haven't done any recent changes except applying security patches for xenforo (although I've overwritten the .php files that I replaced with default ones and no change) and permalinks always worked with the style I'm using.

 

[AtemusVdq]

I have tried to use default style and disable addons from admincp and it's the same result, permalinks only show full thread link, no #post-xxxx number after that.

 

[Mike]

Honestly, I'm pretty baffled. If you submit a ticket referencing this thread, I'll try to get to the bottom of it.

 

[AtemusVdq]

No active updates for current license anymore so probably won't be able to submit a ticket. By the way, I can still see the data-href post number through inspect it's just not added at the end of the href link.

 

[Erel]

Same issue here. Also with XF 1.4.0.
Example: https://www.b4x.com/android/forum/threads/domanda-difficile.76610/

Might be related to another issue that mysteriously started on my forum a few days ago where the upload button stopped working: https://xenforo.com/community/threa...sions-error-drag-and-drop-still-works.126486/

 

[Erel]

More information:
For some reason the generated template file converts the $post object to string:

    <a href="' . XenForo_Template_Helper_Core::link('threads/post-permalink', $thread, array(
'post' => '' . $post
))

If I edit it and change it to:

<a href="' . XenForo_Template_Helper_Core::link('threads/post-permalink', $thread, array(
'post' => $post
))

Then it starts working properly.

Any clues on what can cause this behavior?

 

[Mike]

What's your PHP version?

 

[Erel]

7.0.16

 

[Mike]

There we go then. 1.4 doesn't support PHP 7; it was released after 1.4's "primary" lifecycle. On that basis, I'd have to recommend upgrading to XenForo 1.5 (or downgrading PHP if that's not viable).

There is a workaround for this particular issue posted here: https://xenforo.com/community/threads/php-7-arrays-get-concatenated-in-templates.101873/ But there may not be fixes for other issues.

 

[Erel]

Thank you (we will probably wait till Xenforo 2).

 

[AtemusVdq]

Seems like mistery is solved (thanks for posting @Erel) as I also use php7 but just didn't paid attention to this the day i've updated my php version and well I would have expected xenforo 1.4 to support php7 or atleast release a compatibility patch.

@Mike, I suppose there will be a compatibility patch release for php7? Because downgrading php version doesn't really makes sense and upgrading to 1.5 just for that is a bit dissapointing.

 

[Mike]

There are no plans for a compatibility patch. XenForo 1.4 is currently receiving security patches only. I would have to recommend using the workaround posted if the other solutions aren't viable.

 

[AtemusVdq]

There are no plans for a compatibility patch. XenForo 1.4 is currently receiving security patches only. I would have to recommend using the workaround posted if the other solutions aren't viable.

Yes, already planning this but a workaround is not the same with a compatibility patch. Also could you tell me what gets changed during rebuilding master data? Any chance for permissions or other settings to be modified? Using a custom template, not xenforo default one (of course I'll make a backup before)

Followed the workaround thread and it's fixed. Thank you!