Fixed PayPal processor error: || instead of &&

[Arty]

In library/XenForo/UserUpgradeProcessor/PayPal.php line 250

          $paymentAmountPassed = $paymentAmountPassed || (
             round($this->_filtered['mc_gross'], 2) == round($cost, 2)
             || strtolower($this->_filtered['mc_currency']) == $currency
           );

It should be && on third line of that code instead of || because condition should check if both currency and cost match, not just one of them.

Correct code

          $paymentAmountPassed = $paymentAmountPassed || (
             round($this->_filtered['mc_gross'], 2) == round($cost, 2)
             && strtolower($this->_filtered['mc_currency']) == $currency
           );

 

[Mike]

Indeed, good catch. (Only applied with upgrade extensions, BTW.)