1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Out of date navigations_tab event listener description/arguments

Discussion in 'Resolved Bug Reports' started by Lawrence, Sep 15, 2014.

  1. Lawrence

    Lawrence Well-Known Member

    Not a bug, but as $selectedTabId is no longer used to match the selected tab, the arguments and description for the Navigations_Tab code event listener should be updated to reflect this.
     
  2. Mike

    Mike XenForo Developer Staff Member

    I assume you're just referring to "Select your tab if this matches." Everything else appears to be valid to me.
     
  3. Lawrence

    Lawrence Well-Known Member

    @Mike A while ago, wasn't the selected tab id changed to be determined by the route? I removed the $selectedTabId argument from my navigations tab listener and the proper tabs are highlighted when they, or one of its sub-menu links is clicked.

    I just tried removing the $selectedTabId from the Resource Manager template listener, and the tab still works as intended, so I'm not sure why it is still a required argument.
     
  4. Mike

    Mike XenForo Developer Staff Member

    It just tells you what the ID of the selected tab is. It allows you to react differently based on this.
     
    Lawrence likes this.

Share This Page