Lack of interest Number of user states is hard coded, making it difficult to extend

[Jon W]

In XenForo_ControllerHelper_UserCriteria, there is a filter that checks whether all user states are ticked and, if so, unsets the criteria. This is done by checking whether there are EXACTLY 4 that are ticked, as follows:

        if (isset($criteria['user_state']) && is_array($criteria['user_state']) && count($criteria['user_state']) == 4)
        {
            // all types selected, no filtering
            unset($criteria['user_state']);
        }

This makes it difficult for a developer to add new user criteria, because it means that we have to add some sort of hack to any controller that calls that helper and add back the criteria (or something similar).

It would be much nicer if that number 4 was calculated by counting a static array of all the user states inside that helper (or something similar).

In other words, you would change to:

        if (isset($criteria['user_state']) && is_array($criteria['user_state']) && count($criteria['user_state']) == count(self::$userStates))
        {
            // all types selected, no filtering
            unset($criteria['user_state']);
        }

and then add:

public static $userStates = array('email_confirm','email_confirm_edit','moderated','valid');

to the top of the class.

The array of $userStates could then be easily added to by any add-on to get a correct count.

 

[xf_phantom]

The same problem exists with the genders ( http://xenforo.com/community/threads/user-age-gender-permissions.11363/ )

if (count($criteria['gender']) == 3)
            {
                unset($criteria['gender']);
            }

We've changed it by replacing the whole criteria class (and dozen other classes had to be changed too: / )


And may i ask how you changed the states?( http://xenforo.com/community/threads/alternative-to-enum-db-fields.50736/#post-545338 )

 

[Jon W]

And may i ask how you changed the states?( http://xenforo.com/community/threads/alternative-to-enum-db-fields.50736/#post-545338 )

As you suggested in that thread, some "hacking" is required. I have created a helper function for it in my installer file though, so I don't have a problem with adding enum fields now. My Custom Fields add-on adds enum fields if you want to take a look at that.