As designed Not able to undelete first post of a thread

[AndyB]

Affected version

2.0.1

If the first post of a thread is deleted it cannot be undeleted through post moderation.

 

[Mike]

The first post of a thread can never be deleted -- the thread is deleted instead. The thread itself has to be undeleted.

 

[AndyB]

The first post of a thread can never be deleted

I'm able to select the first post of a thread using inline post moderation and delete the post, which as the message indicates will delete the thread.



Therefore one would assume you should also be able to use inline post moderation to undelete the same post.

 

[Floyd R Turbo]

You can't undelete a post that is part of a deleted thread. I think this is what he is saying.

So if you can see the soft-deleted thread, you can't just undelete the post and expect the thread to then be undeleted. Or is this what you are asking to be done?

I think as long as one understands that deleting the 1st post equals deleting the thread, then they would have to understand that in order to undelete anything in that thread, you have to undelete the thread.

Perhaps changing the phrase "X thread(s) will be deleted when these posts are deleted" to "This action will cause X thread(s) to be deleted" i.e. removing the reference to posts being deleted when they actually aren't => the thread is being deleted instead in those instances

Still, it's just semantics

 

[AndyB]

As it is now it's confusing. You can go through all the motions of undeleting the first post, just that nothing happens. I think a message indicating the first cannot be undeleted would be helpful.

 

[Floyd R Turbo]

Oh I get what you are saying now. When you have either A) deleted a thread or B) deleted the first post of a thread (both of which perform the same action) you can attempt to undelete the first post of that deleted thread, but it doesn't do anything and doesn't throw any kind of error saying that "you can't do that"

IMO, that is sort of a bug

 

[AndyB]

Oh I get what you are saying now. When you have either A) deleted a thread or B) deleted the first post of a thread (both of which perform the same action) you can attempt to undelete the first post of that deleted thread, but it doesn't do anything and doesn't throw any kind of error saying that "you can't do that"

Exactly.

IMO, that is sort of a bug

Seems like a bug to me also.

 

[digitalpoint]

The first post of a thread can never be deleted -- the thread is deleted instead. The thread itself has to be undeleted.

Not entirely true... at least it wasn't always the case. I never really cared much to track it down, and maybe it was fixed in more recent versions, but I have 223 threads that are both deleted with the first post deleted. I think it was some combo with the spam cleaner or post moderation queue, or maybe spam cleaning while the first post is in moderation queue or something.

mysql> SELECT COUNT(*) AS total FROM xf_thread LEFT JOIN xf_post ON (xf_post.post_id = xf_thread.first_post_id) WHERE xf_thread.discussion_state = 'deleted' AND xf_post.message_state = 'deleted';
+-------+
| total |
+-------+
|   223 |
+-------+
1 row in set (0.02 sec)

So we have 223 soft deleted threads that look like this to mods (this is XF1 obviously):