Fixed No legacy add-ons listed after upgrade

[Ranger375]

Uninstalling after the upgrade will remove the add-on from the installed add-on list, but none of the uninstallation code can be performed, so it will leave behind any tables and data.

Before I upgraded I deactivated the addons, but I am not seeing them under the addon list:

 

[Chris D]

Do you see any listed in the xf_addon table in the database?

 

[Ranger375]

Do you see any listed in the xf_addon table in the database?

I do, they all appear to be there:

 

[Chris D]

I'm talking about the core xf_addon table specifically. Are there any entries listed in that table?

 

[Ranger375]

I'm talking about the core xf_addon table specifically. Are there any entries listed in that table?

Four addons are listed in that table.

 

[Chris D]

I think this is a bug. Those four add-ons should be listed and marked as "Legacy add-ons" with an explanation as to what that actually means.

 

[Tom]

I can confirm that this was also the case for me in all 3 beta releases, however it resolved itself once I installed the RM addon, and all the legacy addons were then listed as expected.

 

[Naz]

The index method in the AddOn controller doesn't include legacy add-ons in the total but there's a conditional in the addon_list that checks the total. Straight after an upgrade, it's 0 until there's an installable / upgradeable addon present.

$viewParams = [
    'upgradeable' => $upgradeable,
    'installed' => $installed,
    'installable' => $installable,
    'legacy' => $legacy,
    'total' => count($upgradeable) + count($installed) + count($installable),
    'disabled' => $this->getAddOnRepo()->getDisabledAddOnsCache()
];

 

[Ranger375]

If I want to upgrade an add on in 2.0 can I just install it or would it be best to wait for the fix to upgrade?

 

[Naz]

If I want to upgrade an add on in 2.0 can I just install it or would it be best to wait for the fix to upgrade?

If you have the XF2 version, just upload it and it'll show up in the add-on list along with the missing legacy add-ons.

 

[Fred.]

Now when I read this here I noticed the same in Beta 1, I didn't see the legacy add-ons listed and once I uploaded a XF2 add-on they where listed.
I didn't really think about it, and didn't realise it could be a bug.
I hope this makes it easier to debug.

 

[Chris D]

The total count will now be correct so should display the legacy add-ons if that's all you have.