Fixed multi_quote_macros::button ignores passed add and remove messages

Affected version
2.2.4

Jonathan M

New member
In the button macro in the multi_quote_macros template, 'arg-addMessage' and 'arg-removeMessage' are accepted. They also have default values set.

Code:
<xf:macro name="button"
    arg-href="!"
    arg-messageSelector="!"
    arg-storageKey="!"
    arg-addMessage="{{ phrase('multiquote_add_message') }}"
    arg-removeMessage="{{ phrase('multiquote_remove_message') }}"
    arg-row="{{ false }}">

But deeper inside the macro, these passed values are ignored. Instead, their defaults are used directly.

Code:
<xf:button class="button--link button--multiQuote"
    style="display: none;"
    data-xf-init="multi-quote"
    data-href="{$href}"
    data-message-selector="{$messageSelector}"
    data-storage-key="{$storageKey}"
    data-add-message="{{ phrase('multiquote_add_message') }}"
    data-remove-message="{{ phrase('multiquote_remove_message') }}"
    icon="quote">

The passed values should be used here and the default values only declared once.
 

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.6).

Change log:
Implement the ability to add custom add/remove messages for the multi-quote button.
There may be a delay before changes are rolled out to the XenForo Community.
 
Top