- Affected version
- 2.3.13
Reports on members (content type
On our forum, this meant 112 member reports (on 87 members) went unseen by every staff member since 2021. Before that, from 2014 to 2020, all 552 member reports were handled normally. Nothing told us anything had changed. We only found out because a member report we knew had been filed was missing, and we traced it through the database. Our moderators cleared the backlog after we granted the permission.
It comes from
The report list template then shows any report that fails
This is a problem for several reasons:
user) are only shown to staff who have both "Give users warnings directly" and "Edit basic user profiles". Staff who are missing either permission get no indication that member reports exist. The reports don't appear in the open or closed report lists, the report counter doesn't include them, and there is no warning anywhere in the admin panel.On our forum, this meant 112 member reports (on 87 members) went unseen by every staff member since 2021. Before that, from 2014 to 2020, all 552 member reports were handled normally. Nothing told us anything had changed. We only found out because a member report we knew had been filed was missing, and we traced it through the database. Our moderators cleared the backlog after we granted the permission.
It comes from
XF\Report\UserHandler::canActionContent():
PHP:
return ($visitor->hasPermission('general', 'warn') && $visitor->hasPermission('general', 'editBasicProfile'));
canView() as "Unknown content", and opening it gives a generic error page with nothing in the server error log.This is a problem for several reasons:
- The failure is completely silent. A report that nobody can see is a report that never gets handled. Nothing tells an admin "there are X reports no staff member can view."
- The permission name gives no hint. "Edit basic user profiles" reads like a minor editing power. Nothing about it suggests that it controls whether a whole category of reports is visible.
- It isn't consistent with what the rule is trying to do. The idea seems to be "only show a report to staff who can act on it". But our staff could already act on these members in every meaningful way: warn, ban, spam-clean, and edit the account in the admin panel. The one thing they couldn't do was edit profile fields, which we never do anyway. So we had no reason to grant the permission, and no way to know it mattered.
- Being an administrator doesn't help. I'm an administrator, of course, and saw the same "Unknown content" entry.
- It requires both permissions. Warning a member is a perfectly good way to act on a member report, so requiring profile editing as well seems too strict.
- Give a moderator "Give users warnings directly" but not "Edit basic user profiles".
- As any member, report another member's profile.
- As the moderator, open Reports. The report isn't listed. Search for reports on that member: it shows as "Unknown content" and opening it gives an error.