Fixed Mass revert post edit history endless loop

[dutchbb]

Tried to revert a change to 11k posts, but went over the /amount and keeps going. No php process running that indicates it is working.

I also had to remove 'super admin' from my account to have the option. The changes i wanted to revert are also from other account posts.

 

[dutchbb]

Changes was done by the 'post content find/replace' add on.
https://xenforo.com/community/threads/post-content-find-replace.6548/page-61#post-1130851

I checked some of the posts and my account was in the edit history, also i can change them back 1 by 1.

 

[dutchbb]

Could it be the amount of posts? Limiting to 500 possible solution? I also had to increase the memory_limit to get it working.

fixed! (with the help of @AndyB) was the amount of posts. Limited it to 1 to test en will increase now.

Edit: 50 is max, over that it keeps going.

library/XenForo/Model/EditHistory.php

public function getEditHistoryByUserSinceDate($userId, $cutOff, array $fetchOptions = array())
{
    $joinOptions = $this->prepareEditHistoryFetchOptions($fetchOptions);

    return $this->fetchAllKeyed('
        SELECT history.edit_history_id, history.edit_user_id, history.edit_date
            ' . $joinOptions['selectFields'] . '
        FROM xf_edit_history AS history
        ' . $joinOptions['joinTables'] . '
        WHERE history.edit_user_id = ?
            AND history.edit_date >= ?
        ORDER BY history.edit_date DESC
        LIMIT 1
    ', 'edit_history_id', array($userId, $cutOff));
}

 

[Mike]

I can reproduce this. Close the window to stop the task from running for now. I'm looking into a fix/workaround.

 

[dutchbb]

I can reproduce this. Close the window to stop the task from running for now. I'm looking into a fix/workaround.

Ok thanx stopped it. btw 50 is also not working now, sometimes it does.

 

[Mike]

I believe I've fixed this issue. Currently working via conversation to do some testing (and resolve some issues from the previous run).