1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

XF 1.4 Lose this annoying gap

Discussion in 'Styling and Customization Questions' started by JamesBrown, Sep 18, 2014.

  1. JamesBrown

    JamesBrown Well-Known Member

  2. rainmotorsports

    rainmotorsports Well-Known Member

    Not sure where its floating:
    upload_2014-9-18_6-55-23.png

    The actual logo has a pixel or two top and bottom?
    upload_2014-9-18_6-56-1.png

    Perhaps there is something going on in your screen that I am not experiencing or maybe i misunderstand?

    Oh wait disabled ad blocker. I see it. Lets see. Also thanks for adding the image.
     
    Last edited: Sep 18, 2014
  3. Brogan

    Brogan XenForo Moderator Staff Member

    Remove or reduce the margin top from the ad.
    Set it to 6px instead of 17px if you want it vertically centred.
     
  4. rainmotorsports

    rainmotorsports Well-Known Member

    They may be trying to prevent the login tab from covering the ad. Not sure if thats in the rules or not.

    If the ad's are fixed in size and they don't mind the top margin when the ads are not present... could add it to the logo instead. I know another solution that unfortunately doesn't work with the way the theme is built.
     
  5. Brogan

    Brogan XenForo Moderator Staff Member

    Good point.
    Having a click element over an ad is against Google's TOS.

    It will require a different solution.
    EXTRA.css:
    Code:
    #logo img
    {
        margin-top: 11px;
    }
     
  6. JamesBrown

    JamesBrown Well-Known Member

    Thanks Brogan. It looks much better now (y)
     
  7. Russ

    Russ Well-Known Member

    Not quite, logged out is messed up now.
     
  8. Brogan

    Brogan XenForo Moderator Staff Member

    I did it logged out.
    What are you seeing Russ?

    Edit: I presume you're browsing with a small screen? Yes, you'll need to remove margin top using a media query for when it's less than max width.
     
  9. Russ

    Russ Well-Known Member

    Nope:

    Screenshot_7.png
     
  10. Brogan

    Brogan XenForo Moderator Staff Member

    Ahh, you have ads blocked.

    Personally I'd ditch the ad in the header, as that is what's causing the issues.
    Either that or make the logo the same height as the ad.
     
  11. Russ

    Russ Well-Known Member

    Looks like removing the margin-top on the logo, and setting the margin top on the ad: 6px will make it work with or without the ads.
     
  12. Brogan

    Brogan XenForo Moderator Staff Member

    Russ likes this.
  13. JamesBrown

    JamesBrown Well-Known Member

    Thanks Russ and Brogan. Where will I find that margin setting on the logo and the top of the ad?. Cheers
     
  14. JamesBrown

    JamesBrown Well-Known Member

    Sorted (I think)

    Style Properties: Header and Navigation > Height of Header Logo Added 5px

    Thanks again.
     

Share This Page