1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Long search type yields server error

Discussion in 'Resolved Bug Reports' started by digitalpoint, Sep 9, 2013.

  1. digitalpoint

    digitalpoint Well-Known Member

    If you have users who think it's cute to alter the search type by hand, you can end up with a whole lot of server errors being logged because the search type trying to be stored is more than the 25 characters allowed by the schema...

    For example, this URL will give a server error:

    http://xenforo.com/community/search/1/?q=hello world&t=long_search_type_yields_server_error&o=date
     
    Last edited by a moderator: Sep 10, 2013
  2. Chris D

    Chris D XenForo Developer Staff Member

    * Mike logs in to Admin CP
    * Sees full Server Error Log

    Mike: What the ....
     
  3. RoldanLT

    RoldanLT Well-Known Member

    It logs 3 error on my board, nice spot (y)
     
    Adam Howard likes this.
  4. Mike

    Mike XenForo Developer Staff Member

    Fixed (locally). There isn't really much significance other than the error log.

    However, in this situation, it doesn't make sense to even have the search type. The type can be used to do a content-type-specific search. If it can't find the type, it automatically flips back to a global search. As such, I believe it makes sense to wipe out the type in that case.
     
    Adam Howard and Chris D like this.
  5. digitalpoint

    digitalpoint Well-Known Member

    Yeah... Agreed it didn't matter much other than server log. In my case, it was a script kiddie that ended up putting thousands of entries in my server log... Which sort of rendered the server log useless because I wasn't going to look through them all in case any legit items were logged.
     
    Adam Howard likes this.

Share This Page