Fixed Logout gives redirection error

[Paul B]

I don't believe before 1.0.3 it would log me out of Facebook entirely if I logged out of the forum.

I'm fairly sure it did.

 

[Will]

I'm fairly sure it did.

I may be wrong but I don't remember having to sign in again on Facebook.

Edit: Nvm, you're right I guess I never noticed it.

 

[Brett Peters]

commenting out the line in xenforo.js does not fix the issue for me either, When this issue is fixed on xenforo.com could someone please post the solution.

Having to delete cookies after logging out with FB to continue to navigate/browse

 

[Mike]

Two notes about the workaround:

1. The xenforo.js file may be cached. Do a hard refresh.
2. It will only prevent the issue when you click log out. If it's in the refresh loop, it likely won't do anything.

 

[Alex Vojacek]

You guys need to do a full refresh, clean cache of web browsers.
I happen to have various machines at home and doing the change and login in and out from a machine i've never logged to my xenforo before worked perfectly.
My machine did not worked even after doing Ctrl-F5, had to clean up the cache and do a full Ctrl-F5 twice. Chrome is worse than that.
I would test this with IE8, since it's cache system sucks.

This WILL work if you're having the facebook problem I am SURE of it, removing the line disconnects xenforo from loggin out of facebook so, basically the problem is gone.

 

[Brett Peters]

I was on chrome (14.0.803.0 dev) when I got stuck in Error/Refresh loop both on my site and XF which is when clear browser data had to be used to be able to view the site'(s) again, I will have a further play around tomorrow.

 

[Paul B]

Chrome is terrible for clearing cache.
I usually have to press CTRL+F5 2 or more times.

 

[Alex Vojacek]

Chrome is terrible for clearing cache.
I usually have to press CTRL+F5 2 or more times.

I feel soo much like you. I discovered that for developing, there is nothing better than firefox in "private-browsing" mode. Chrome is a disaster for trying stuff.

 

[Brandon Sheley]

general-forums.com/logout/?redirect=http://general-forums.com/logout/?redirect=http://general-forums.com/logout/?redirect=http%3A//general-forums.com/logout/%3Fredirect%3Dhttp%253A//general-forums.com/logout/%253Fredirect%253Dhttp%25253A//general-forums.com/logout/%25253Fredirect%25253Dhttp%2525253A//general-forums.com/logout/%2525253Fredirect%2525253Dhttp%252525253A//general-forums.com/logout/%252525253Fredirect%252525253Dhttp%25252525253A//general-forums.com/logout/%25252525253Fredirect%25252525253Dhttp%2525252525253A//general-forums.com/logout/%2525252525253Fredirect%2525252525253Dhttp%252525252525253A//general-forums.com/logout/%252525252525253Fredirect%252525252525253Dhttp%25252525252525253A//general-forums.com/logout/

 

[Mike]

Removing these 2 lines from js/xenforo/xenforo.js might be a safer workaround, as it will prevent the loop from happening (ie, for people that already triggered it):

location += (location.indexOf('?') >= 0 ? '&' : '?') + 'redirect=' + escape(window.location);
window.location = XenForo.canonicalizeUrl(location);

 

[Brandon Sheley]

Removing these 2 lines from js/xenforo/xenforo.js might be a safer workaround, as it will prevent the loop from happening (ie, for people that already triggered it):

location += (location.indexOf('?') >= 0 ? '&' : '?') + 'redirect=' + escape(window.location);
window.location = XenForo.canonicalizeUrl(location);

okay, I commented out the one line from the first page, should I un-commented that and commented out the lines you just mentioned?

 

[Mike]

okay, I commented out the one line from the first page, should I un-commented that and commented out the lines you just mentioned?

You can do both.

The first page example removes the logout from Facebook (which prevents the redirect loop from starting).

The lines here will prevent the redirect loop from starting or from being triggered if you're not logged into Facebook (but are logged in to XF).

 

[Mike]

Fixed now, though the full fix is quite extensive (including a couple template changes). The workarounds I posted (one or the other, or both) should work in the mean time. If you get in the redirect loop, the issue should also go away once your session becomes invalid (after an hour of inactivity, usually).

 

[Phillip]

Fixed now, though the full fix is quite extensive (including a couple template changes). The workarounds I posted (one or the other, or both) should work in the mean time. If you get in the redirect loop, the issue should also go away once your session becomes invalid (after an hour of inactivity, usually).

Will we see an update to 1.03 soon correcting this issue? We are planning to update to 1.03 tomorrow but will hold off if a fix is coming soon.

 

[Paul B]

I suspect the full fix will be rolled out with 1.0.4 or 1.1, whichever comes first.

 

[Floris]

Fixed now, though the full fix is quite extensive (including a couple template changes). The workarounds I posted (one or the other, or both) should work in the mean time. If you get in the redirect loop, the issue should also go away once your session becomes invalid (after an hour of inactivity, usually).

*fist at facebook* you darn you !!

Thanks Mike for looking into this, I noticed this issue as well, but couldn't figure out where it came from. Glad it's as resolved as can be. Big plus one for keeping looking into this and communicating it to us.

 

[Alex Vojacek]

I'm the happier user here, since I initially reported the bug and the speed at which the team worked to solve it is awesome, big kudos !

 

[zxleo]

im just disable the facebook integration and i dont have some errors :S

Sorry for my bad english D: !

 

[Julio Franco]

I believe this is going on my forums, with the difference that I'm running the latest version.

I'm getting a redirect loop upon logging in with Facebook. The login is successful if go back manually to www.techspot.com, however the result of clicking the login button is an error page (redirect loop) if I'm already logged in on the Facebook side. Doesn't happen if I'm not logged in Facebook already.