1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Logo Height

Discussion in 'Resolved Bug Reports' started by yoghurtfarmer, Oct 5, 2010.

  1. yoghurtfarmer

    yoghurtfarmer Well-Known Member

    In header.css,

    Shouldn't 35px be @headerLogoHeight?

    Code:
            #logo img
            {
                vertical-align: middle;
                height: 35px;
            }
     
    CyberAP likes this.
  2. Elizabeth

    Elizabeth Well-Known Member

    No, it works like that, if you want to change it, that's where you do that.
     
  3. yoghurtfarmer

    yoghurtfarmer Well-Known Member

    If the option in AdminCP was Height of Header rather than "Height of Header Logo" then I would agree.

    Either way, it's minor.
     
  4. Elizabeth

    Elizabeth Well-Known Member

    You have to change both if you change your logo height from 35 to another. The one in the ACP styles is the height of the header piece not the logo.
     
  5. yoghurtfarmer

    yoghurtfarmer Well-Known Member

    Yes yes I know :p. I got it to work.

    It was just not the expected behaviour given the wording.
     
  6. Mike

    Mike XenForo Developer Staff Member

    Actually that line of CSS likely shouldn't be there at all.
     
    CyberAP likes this.
  7. Elizabeth

    Elizabeth Well-Known Member

    Well, this thread will be helpful for others. Glad you got it to work.
     
  8. crossovernetwork

    crossovernetwork Active Member

    where about is header.css? I'm looking for it but can't find it.
     
  9. Lycaon

    Lycaon Well-Known Member

    Appearance > Templates > StyleName

    Scroll down until you find it or type header in the filter items field.
     
    Rob Fritz likes this.
  10. crossovernetwork

    crossovernetwork Active Member

    thanks. :) I was looking for a header.css file... D'OH!
     
  11. CyberAP

    CyberAP Well-Known Member

    Hope this value will be replaced with @headerLogoHeight in future releases.
     
  12. Robert F Schmitz

    Robert F Schmitz Well-Known Member

    OK as a n00b, stupid question. I got the image height set correctly with the 35px to my setting but where do I make the change to shift everything down to clear the image? Thanks in advance.
     
  13. RickM

    RickM Well-Known Member

    Also had this problem. I ended up ripping out the logo height settings as I know my logo is never going to need to be shrunk down. Didnt see much point using CSS to fix the height of an image if its full size is what you need. Hardly anyone is going to be using a big logo, then setting its width/height smaller - that would silly.

    There's also a setting that positions the header at the top and sets it's height. I found once I had replaced my logo, it was causing the header to become misaligned and too big. So ended up taking out that piece of CSS too. Tested on all browsers and it works fine without it.
     
    Rob Fritz likes this.
  14. Robert F Schmitz

    Robert F Schmitz Well-Known Member

    Could you tel me how to do this? Thanks.
     
  15. RickM

    RickM Well-Known Member

    In the Admin area go to the template manager for your style. Then search for public.css and open it up.

    Find:
    Code:
    	#headerMover #headerProxy
    	{
    		@property "header.background";
    		background-color: @primaryMedium;
    		@property "/header.background";
    		height: {xen:calc '@headerLogoHeight + @headerTabHeight * 2 + 2'}px;*/ /* +2 borders */
    	}
    
    You want to remove the height entry. There's also a bug - it looks like it should have been commented out as the closing comment is still there just before the +2 borders bit :/

    Anyway, for my style I took the height out all together as I didn't need it (I'm not using the standard tab area). Obviously you could change it to a different value if you wanted.

    Hope that helps!
     
    Rob Fritz likes this.

Share This Page