Fixed Lightbox sidebar missing for Embeds, Videos and Audio media types

[marquisite]

Affected version

2.3.2

The lightbox sidebar is missing for embed, video and audio media types. This is happening with XFMG 2.3.2 and here on XenForo.com at the time of posting. The sidebar does correctly display for images.

Upon checking the browser console, an uncaught TypeError is logged for the XF2.3 lightbox (in the case of embeds, videos and audio):

Uncaught TypeError: b.contentEl is undefined
    onSlideDisplayed https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:15
    trigger https://xenforo.com/community/js/xf/core-compiled.js?_v=f87c062b:8
    Carousel.ready Carousel.change https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:26
    emit https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    emit https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    initCarousel https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    emit https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    emit https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    emit https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    init https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1
    processOptions https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:1

A similar uncaught TypeError happens when using the prev/next lightbox buttons to navigate to a non-image media item:

Uncaught TypeError: b.slide is undefined
    onSlideDisplayed https://xenforo.com/community/js/xf/lightbox-compiled.js?_v=f87c062b:16

 

[M@rc]

I was just about to report this:

Media

xenforo.com

Click a video media item -> click the arrow to view the next video media item in the lightbox

The sidebar loads forever.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XFMG release (2.3.4).

Change log:

Fix sidebar not loading for videos/embeds.

There may be a delay before changes are rolled out to the XenForo Community.

 

[M@rc]

Is this live on xenForo.com? Because it isn't working (here) sadly.

 

[Chris D]

Well, that's infuriating

I promise it was working earlier. In fact, it does seem to be working for embeds now. It's some sort of annoying race condition which is mostly down to the underlying library.

 

[Old Nick]

I get this error in the console:

 

[M@rc]

Notice how the URL of the page doesn't update in the browser address bar when you shift through the media videos too. You can hear the audio from the previous media video when you're on the new media.

 

[stromb0li]

Notice how the URL of the page doesn't update in the browser address bar when you shift through the media videos too. You can hear the audio from the previous media video when you're on the new media.

Yeah I reported this back in first beta, confirmed, but it's just sat pending

S

Confirmed Thread 'XFMG: Videos continue to play when viewing another album item'

Mar 21, 2024

If viewing an album and the media is of type video, once you press play, if you click the arrow to browse the next item in the album, the previous will continue to play instead of stopping the previous video.

Repo can be done on XF website.

Test videos

Use this if you want to try out uploading videos. Videos will be transcoded to H264/AAC where necessary. Please be sure to follow our general rules. First and foremost, this is still a business forum!

xenforo.com

Play the Independence Day clip then click next and press play on Big Buck Bunny. You'll hear both audio tracks play at the same time.

Edit: Sorry to posting in wrong area, can you please help move this to the Media Gallery forum

• stromb0li
• Replies: 1
• Forum: Media Gallery bug reports

 

[Andy.N]

I get this error in the console:

View attachment 313130

Same error.
This is going to be fixed in 2.3.5 or is there a patch for the time being?

 

[M@rc]

This is going to be fixed in 2.3.5 or is there a patch for the time being?

Chris posted a test yesterday so it's likely still being looked into despite the "fixed" prefix.