[Liam W.] Post Macros

[Liam W.] Post Macros 5.3.0 Fix 3

No permission to download
After updating to v5.3.0, apparently the {thread_author} variable stopped working in direct messages.
 
After updating to v5.3.0, apparently the {thread_author} variable stopped working in direct messages.
I also get the following errors when editing a macro in the admin cp:

Code:
ErrorException: Template error: [E_USER_WARNING] Template public:liamw_postmacros_iconpicker_macros is unknown
src\XF\Template\Templater.php:782
Generated by: -
31 Aug 2024 at 22:17
[HEADING=2]Stack trace[/HEADING]
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, '[E_USER_WARNING...', 'C:\\inetpub\\wwwr...', 782)
#1 src\XF\Template\Templater.php(782): trigger_error('Template public...', 512)
#2 src\XF\Template\Templater.php(743): XF\Template\Templater->getTemplateData('public', 'liamw_postmacro...')
#3 src\XF\Template\Templater.php(868): XF\Template\Templater->getTemplateMacro('public', 'liamw_postmacro...', 'liamw_postmacro...')
#4 internal_data\code_cache\templates\l4\s0\admin\liamw_postmacros_edit.php(99): XF\Template\Templater->callMacro('liamw_postmacro...', 'liamw_postmacro...', Array, Array)
#5 src\XF\Template\Templater.php(1792): XF\Template\Templater->{closure}(Object(NF\Tickets\XF\Template\Templater), Array, NULL)
#6 src\addons\MaZ\AUN\XF\Template\Templater.php(39): XF\Template\Templater->renderTemplate('liamw_postmacro...', Array, true, NULL)
#7 src\XF\Template\Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('admin:liamw_pos...', Array)
#8 src\XF\Mvc\Renderer\Html.php(50): XF\Template\Template->render()
#9 src\XF\Mvc\Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('LiamW\\PostMacro...', 'admin:liamw_pos...', Array)
#10 src\XF\Mvc\Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#11 src\XF\Mvc\Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#12 src\XF\Mvc\Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#13 src\XF\App.php(2813): XF\Mvc\Dispatcher->run()
#14 src\XF.php(802): XF\App->run()
#15 admin.php(15): XF::runApp('XF\\Admin\\App')
#16 {main}

and:
Code:
ErrorException: Template error: [E_USER_WARNING] Macro public:liamw_postmacros_iconpicker_macros:liamw_postmacros_icon_picker is unknown
src\XF\Template\Templater.php:749
Generated by: -
31 Aug 2024 at 22:17
[HEADING=2]Stack trace[/HEADING]
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, '[E_USER_WARNING...', 'C:\\inetpub\\wwwr...', 749)
#1 src\XF\Template\Templater.php(749): trigger_error('Macro public:li...', 512)
#2 src\XF\Template\Templater.php(868): XF\Template\Templater->getTemplateMacro('public', 'liamw_postmacro...', 'liamw_postmacro...')
#3 internal_data\code_cache\templates\l4\s0\admin\liamw_postmacros_edit.php(99): XF\Template\Templater->callMacro('liamw_postmacro...', 'liamw_postmacro...', Array, Array)
#4 src\XF\Template\Templater.php(1792): XF\Template\Templater->{closure}(Object(NF\Tickets\XF\Template\Templater), Array, NULL)
#5 src\addons\MaZ\AUN\XF\Template\Templater.php(39): XF\Template\Templater->renderTemplate('liamw_postmacro...', Array, true, NULL)
#6 src\XF\Template\Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('admin:liamw_pos...', Array)
#7 src\XF\Mvc\Renderer\Html.php(50): XF\Template\Template->render()
#8 src\XF\Mvc\Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('LiamW\\PostMacro...', 'admin:liamw_pos...', Array)
#9 src\XF\Mvc\Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#10 src\XF\Mvc\Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#11 src\XF\Mvc\Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#12 src\XF\App.php(2813): XF\Mvc\Dispatcher->run()
#13 src\XF.php(802): XF\App->run()
#14 admin.php(15): XF::runApp('XF\\Admin\\App')
#15 {main}
 
After updating to v5.3.0, apparently the {thread_author} variable stopped working in direct messages.
“thread_author” for direct messages?
It's a bit logical that it doesn't work, “thread author” is for threads and not for direct messages.
I also get the following errors when editing a macro in the admin cp:

Code:
ErrorException: Template error: [E_USER_WARNING] Template public:liamw_postmacros_iconpicker_macros is unknown
src\XF\Template\Templater.php:782
Generated by: -
31 Aug 2024 at 22:17
[HEADING=2]Stack trace[/HEADING]
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, '[E_USER_WARNING...', 'C:\\inetpub\\wwwr...', 782)
#1 src\XF\Template\Templater.php(782): trigger_error('Template public...', 512)
#2 src\XF\Template\Templater.php(743): XF\Template\Templater->getTemplateData('public', 'liamw_postmacro...')
#3 src\XF\Template\Templater.php(868): XF\Template\Templater->getTemplateMacro('public', 'liamw_postmacro...', 'liamw_postmacro...')
#4 internal_data\code_cache\templates\l4\s0\admin\liamw_postmacros_edit.php(99): XF\Template\Templater->callMacro('liamw_postmacro...', 'liamw_postmacro...', Array, Array)
#5 src\XF\Template\Templater.php(1792): XF\Template\Templater->{closure}(Object(NF\Tickets\XF\Template\Templater), Array, NULL)
#6 src\addons\MaZ\AUN\XF\Template\Templater.php(39): XF\Template\Templater->renderTemplate('liamw_postmacro...', Array, true, NULL)
#7 src\XF\Template\Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('admin:liamw_pos...', Array)
#8 src\XF\Mvc\Renderer\Html.php(50): XF\Template\Template->render()
#9 src\XF\Mvc\Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('LiamW\\PostMacro...', 'admin:liamw_pos...', Array)
#10 src\XF\Mvc\Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#11 src\XF\Mvc\Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#12 src\XF\Mvc\Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#13 src\XF\App.php(2813): XF\Mvc\Dispatcher->run()
#14 src\XF.php(802): XF\App->run()
#15 admin.php(15): XF::runApp('XF\\Admin\\App')
#16 {main}

and:
Code:
ErrorException: Template error: [E_USER_WARNING] Macro public:liamw_postmacros_iconpicker_macros:liamw_postmacros_icon_picker is unknown
src\XF\Template\Templater.php:749
Generated by: -
31 Aug 2024 at 22:17
[HEADING=2]Stack trace[/HEADING]
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, '[E_USER_WARNING...', 'C:\\inetpub\\wwwr...', 749)
#1 src\XF\Template\Templater.php(749): trigger_error('Macro public:li...', 512)
#2 src\XF\Template\Templater.php(868): XF\Template\Templater->getTemplateMacro('public', 'liamw_postmacro...', 'liamw_postmacro...')
#3 internal_data\code_cache\templates\l4\s0\admin\liamw_postmacros_edit.php(99): XF\Template\Templater->callMacro('liamw_postmacro...', 'liamw_postmacro...', Array, Array)
#4 src\XF\Template\Templater.php(1792): XF\Template\Templater->{closure}(Object(NF\Tickets\XF\Template\Templater), Array, NULL)
#5 src\addons\MaZ\AUN\XF\Template\Templater.php(39): XF\Template\Templater->renderTemplate('liamw_postmacro...', Array, true, NULL)
#6 src\XF\Template\Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('admin:liamw_pos...', Array)
#7 src\XF\Mvc\Renderer\Html.php(50): XF\Template\Template->render()
#8 src\XF\Mvc\Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('LiamW\\PostMacro...', 'admin:liamw_pos...', Array)
#9 src\XF\Mvc\Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#10 src\XF\Mvc\Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#11 src\XF\Mvc\Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#12 src\XF\App.php(2813): XF\Mvc\Dispatcher->run()
#13 src\XF.php(802): XF\App->run()
#14 admin.php(15): XF::runApp('XF\\Admin\\App')
#15 {main}
Yes indeed I will publish an update for that
 
It is logical indeed, however it DID work before the upgrade. Any chance to get it back?
Unfortunately not, because if it worked before (which it obviously doesn't because see my screen XF version: 2.2.16, addon version: [Liam W.] Post Macros 5.2.2 Fix 8) I don't know how it could work.

1725227930816.webp
small tips if you want to be able to do conversation_author you have to add a variabel in the option : liamw_postmacros_placeholders
Add this :
Code:
conversation_author=>conversation.Starter.username
 
This addon seems to create a huge number of permission rebuild jobs running the LiamW\PostMacros:EnrollmentRebuild class, which causes performance issues when doing something like installing addons as it runs though all the permission rebuild jobs. Do you know why this might be?
 
This addon seems to create a huge number of permission rebuild jobs running the LiamW\PostMacros:EnrollmentRebuild class, which causes performance issues when doing something like installing addons as it runs though all the permission rebuild jobs. Do you know why this might be?
@XenSoluce any ideas about this question?
 
This addon seems to create a huge number of permission rebuild jobs running the LiamW\PostMacros:EnrollmentRebuild class, which causes performance issues when doing something like installing addons as it runs though all the permission rebuild jobs. Do you know why this might be?
@XenSoluce any ideas about this question?
When we took over the addon, this task was executed when you saved permissions, which caused problems, as it indicated that a task was still running.
For this reason, this task is no longer executed.
To execute this task, go to rebuild.

To answer your question, this Job is no longer executed.
 
This addon seems to create a huge number of permission rebuild jobs running
The query count increases pretty substantially with this add-on installed..

There is something going on with this addon where it’s creating so much load on the database that it’s creating issues.
Why is there a cron job, anyway?

This is an excellent modification @Oblivion Knight makes moderation tasks much, much easier!
@mattgrogowski - are these similar issues to yours ?

This is an excellent modification @Oblivion Knight makes moderation tasks much, much easier!
how ?

Is this an example of "Post Macros" ? (see the dropdowns)

1728248476669.webp
 
hmm did this break recently? or is it me....just noticed links to macros now resulting as:

Oops! We ran into some problems.​

The requested page could not be found.

XF 2.3.6(confirmed on a mostly default stage)
no broken template mods...

regards
 
Back
Top Bottom