XF 2.2 LESS and container queries

[Newsman]

Hey there!

Sooo I was wondering: did I get it right that for now container queries do not work with the LESS version included in Xenforo? Is there any way to make them work? Do I have to update LESS somehow?

Cheers!

 

[Paul B]

Can you clarify what you mean by container queries.

Do you mean var if statements, or viewport width, or @container , or something else?

 

[Newsman]

Oh sorry!

I mean

@container

 

[digitalpoint]

Probably not. @container is a relatively new thing introduced to LESS, and the library XenForo uses for LESS hasn't been updated in many years:

GitHub - oyejorge/less.php: less.js ported to PHP.

less.js ported to PHP. Contribute to oyejorge/less.php development by creating an account on GitHub.

github.com

In fact the developer has deprecated/archived the library and recommends people switch to a "well-maintained fork":

GitHub - wikimedia/less.php: Less.js ported to PHP. Mirrored from https://gerrit.wikimedia.org/g/mediawiki/libs/less.php/

Less.js ported to PHP. Mirrored from https://gerrit.wikimedia.org/g/mediawiki/libs/less.php/ - wikimedia/less.php

github.com

It probably makes sense for XenForo to update/switch the LESS library they are using (that's a different thing though), but even the new recommended one doesn't yet support @container. See:

Support @container queries (Less.js 4.2.0) · Issue #91 · wikimedia/less.php

As reported in #78 (comment). I made a very rough "fix": Gappa@d255214 It kind of works, but hijacks most of the code for media queries, upon which container queries are based, so it makes at least...

github.com

 

[Newsman]

Probably not. @container is a relatively new thing introduced to LESS, and the library XenForo uses for LESS hasn't been updated in many years:

GitHub - oyejorge/less.php: less.js ported to PHP.

less.js ported to PHP. Contribute to oyejorge/less.php development by creating an account on GitHub.

github.com

In fact the developer has deprecated/archived the library and recommends people switch to a "well-maintained fork":

GitHub - wikimedia/less.php: Less.js ported to PHP. Mirrored from https://gerrit.wikimedia.org/g/mediawiki/libs/less.php/

Less.js ported to PHP. Mirrored from https://gerrit.wikimedia.org/g/mediawiki/libs/less.php/ - wikimedia/less.php

github.com

It probably makes sense for XenForo to update/switch the LESS library they are using (that's a different thing though), but even the new recommended one doesn't yet support @container. See:

Support @container queries (Less.js 4.2.0) · Issue #91 · wikimedia/less.php

As reported in #78 (comment). I made a very rough "fix": Gappa@d255214 It kind of works, but hijacks most of the code for media queries, upon which container queries are based, so it makes at least...

github.com

That is unfortunate, especially considering how handy the new query is Thanks for clearing this up!

 

[Jeremy P]

It probably makes sense for XenForo to update/switch the LESS library they are using (that's a different thing though), but even the new recommended one doesn't yet support @container. See:

This doesn't help with @container support, but wanted to note we have already upstreamed the outstanding minor changes from our fork to Wikimedia and switched to their fork for 2.3, though we are constrained to v3.2 for PHP compatibility.