XF 2.0 Is it possible to extend XF\Http

[AndyB]

I would like to create a XF2 version of an add-on called Open PDF which will open an attached PDF document instead of downloading it, I need to add the following line of code to this file:

XF\Http\Response.php



Is it possible to extend the XF\Http and specifically this protected item?

Thank you.

 

[Robust]

\XF\Http\Response is not dynamically loaded (with extendClass), so you can't extend the class.

That variable is referenced in this function:

    public function setAttachmentFileParams($fileName, $extension = null)
    {
        if ($extension === null)
        {
            $extension = pathinfo($fileName, PATHINFO_EXTENSION);
        }

        $extension = strtolower($extension);

        if ($extension && isset($this->inlineDisplaySafeTypes[$extension]))
        {
            $this->contentType($this->inlineDisplaySafeTypes[$extension], '')
                ->setDownloadFileName($fileName, true);
        }
        else
        {
            $this->contentType('application/octet-stream', '')
                ->setDownloadFileName($fileName);
        }

        return $this;
    }

So you could perhaps just use the relevant part of the code, contentType and setDownloadFileName are public functions, and simply bypass this method.

Something like:

$response->contentType('application/pdf', '')->setDownloadFileName($fileName), true)

 

[AndyB]

Thank you, Robust. Your tip is exactly the information I needed.