• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Installer escapes double quote

Jake B.

Well-known member
#1
Currently the XenForo installer escapes the double quote with a backslash if it's used in your database password, even though it is stored in single quotes which prevents installation from taking place. It's caused in library/XenForo/Install/Model/Install.phph on line 392:
Code:
$lines[] = '$config[\'' . addslashes($key) . '\'][\'' . addslashes($subKey) . '\'] = \'' . addslashes($subValue) . '\';';
And should probably use something like this:
Code:
$str = str_replace('\'', '\\\'', str_replace('\\', '\\\\', $str));
Since there is no reason to escape double quotes in this circumstance.
 

Mike

XenForo developer
Staff member
#2
I actually just switched it to addcslashes() as it's a bit more succinct, but fixed now thanks. :)