Fixed Highest Reaction score limits users shown whatever you set

[Mr Lucky]

Affected version

2.1

In the member statistics, you can set a really high number (e.g.>1000) for most messages however whatever you set fo Highest reaction score is cut off at (approx) 50 or something.

 

[Chris D]

I suspect that this resolved itself for you automatically after approximately one hour.

That's how long the member statistic results are cached for. We actually cache 3 times whatever the limit is (default 20), so by default 60 users. That then allows us to remove certain users from the list and we can always ensure the desired limit is returned.

Your cache for highest reaction score would most likely have contained about 60 users. When you increased the limit to 1000, the cache still only contained 60 users, so only 60 users were returned.

Up to an hour later, the cache will have expired and it would have been rebuilt to contain the desired 1000 users (well, actually, 3000).

Clear as mud? Good.

I have made a small change though so that changing the user_limit automatically invalidates the results cache. So that should fix it.

 

[Mr Lucky]

Up to an hour later, the cache will have expired and it would have been rebuilt to contain the desired 1000 users (well, actually, 3000).

I did not actually sit there counting so I have to believe you. And I have no reason not to.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.2).

Change log:

Invalidate the member stat results cache when the user limit changes.

Any changes made as a result of this issue being resolved may not be rolled out here until later.