1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

XF 1.4 Help! Certain links open up a google search for Javascript:void(0)

Discussion in 'Troubleshooting and Problems' started by Stuart Wright, May 13, 2015.

  1. Stuart Wright

    Stuart Wright Well-Known Member

    Started happening today and it's happening for everyone irrespective of browser.
    For example, start a new conversation and click the smilies button.
    Bang. Javascript void google search opens in the same browser window.
    Obviously AVForums is fairly broken right now.
    Can anyone help please?
     
  2. Chris D

    Chris D XenForo Developer Staff Member

  3. Stuart Wright

    Stuart Wright Well-Known Member

    Removed the tag manager script. It's still happening and I *think* my cache has caught up.
    Edit: yep, still happening. Thanks for repying, Chris. Any other ideas?
     
  4. Stuart Wright

    Stuart Wright Well-Known Member

    Doing
    $config['enableListeners'] = false;
    in the config disables all addons, right?
    I did that and the problem is still there.
     
  5. Chris D

    Chris D XenForo Developer Staff Member

    How long has the problem been occurring? Have you made any recent changes? Installed or updated any recent add-ons?
     
  6. Stuart Wright

    Stuart Wright Well-Known Member

    The first report from members is at 4:16pm from what I can see.
    https://www.avforums.com/threads/javascript-void-null.1957654/
    I edited an unused static page to repurpose it and make it available to certain usergroups
    https://www.avforums.com/pages/advertisers-code-of-conduct/
    and I moved several thousands threads from quiet forums into parent ones and then moved the empty forums out of the way.
    That's it for me.
    John Warwick did some stuff editorial related, but I don't know what and he's on Hong Kong time, so unavailable right now.
    He said he was doing an update from our Youtube channel to populate the database with out-of-date data.
    He may have been working on the SHOW MORE button in editorial pages (like the home page) which is buggy. That's JS related.

    The first thing I noticed was at 17:33 when I saw that the links to the videos in our MEDIA widget on the home page were behaving weirdly. I fixed those by putting noskim round the links.

    It's almost like the server is making links with JS actions open the URL in addition to firing the desired JS actions.
     
    Last edited: May 13, 2015
  7. Chris D

    Chris D XenForo Developer Staff Member

    The problem went away briefly, did you do anything?
     
  8. Stuart Wright

    Stuart Wright Well-Known Member

  9. Stuart Wright

    Stuart Wright Well-Known Member

    I can't reproduce the error, now.
    Edit: yes I can. In Chrome.
     
  10. Chris D

    Chris D XenForo Developer Staff Member

    I can in conversations
     
  11. Stuart Wright

    Stuart Wright Well-Known Member

    So weird! Happens in all the styles I tried, also. Chatted with Tim and he's 99% sure it's not a server issue.
     
  12. Chris D

    Chris D XenForo Developer Staff Member

    I was in the process of disabling/enabling template modifications when it happened. Of course these aren't disabled when listeners are disabled so that means it could still be an add-on.

    So I'm going to disable all add-ons properly and have another look.
     
    Stuart Wright likes this.
  13. Chris D

    Chris D XenForo Developer Staff Member

    What are the chances. Started disabling them all in alphabetical order and the culprit was in the A's!

    Just testing it with all others enabled now...
     
  14. Stuart Wright

    Stuart Wright Well-Known Member

    Well that's very odd, because I haven't touched any addons today.
     
  15. Chris D

    Chris D XenForo Developer Staff Member

    It's Skimlinks.

    Not the add-on, but Skimlinks itself. If you take the code out and just put the recommended code from Skimlinks into a template directly, it still breaks everything.

    So, one to have a word with them about.
     
    jeffwidman and thumped like this.
  16. Stuart Wright

    Stuart Wright Well-Known Member

    So they have changed their code today, obviously.
    I'm going to have a serious word with them tomorrow.
    Thank you so much, Chris.

    I want to also thank Tim from Nimbus who worked this evening to check that there was no server issue. There was not.
     
    Last edited: May 13, 2015
  17. Stuart Wright

    Stuart Wright Well-Known Member

    We should probably put some kind of alert up to let other Skimlinks users know of the issue.
     
  18. BamaStangGuy

    BamaStangGuy Well-Known Member

    Viglink screwed us in a similar way.
     
  19. briansol

    briansol Active Member

    I run skimlinks and am not seeing anything broken...
     
  20. Stuart Wright

    Stuart Wright Well-Known Member

    They emailed me last night to say that the issue is isolated to AVForums and they have rolled back the change they made.
     

Share This Page