Force Style On Thread Prefix 1.0.2

[Chris D]

Chris Deeming submitted a new resource:

Force Style On Thread Prefix (version 1.0) - Extra thread prefix option to override the style on a thread based on the thread prefix

​

​

Thank you so much for donating. It is always appreciated!​

​

Read more about this resource...

 

[Mutt]

this looks very cool

 

[ArnyVee]

Very cool Chris! I'm going to look into this at a later date as I have some ideas for this

Thanks for allowing it to be shared Luxus!

 

[Luxus]

I have possibly found a bug in this addon. Although it could be related to Widget Framework.

Undefined property: XenForo_ControllerResponse_Redirect::$params
 
    XenForo_Application::handlePhpError() in ForceStyleOnPrefix/ControllerPublic/Thread.php at line 9
    ForceStyleOnPrefix_ControllerPublic_Thread->actionIndex() in XenForo/FrontController.php at line 310
    XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 132
    XenForo_FrontController->run() in C:/Winginx/home/xen/index.php at line 13

This error occured as follows:

I have the recent threads widget of widget framework. It shows recent X threads. One of the threads has a prefix. I moved this thread to a forum with no prefixes. Thread has been moved successfully and of course the prefix disappeared. But now the thread is displayed twice in the recent threads widget. The first is the thread from the original location and the second is the thread moved to a different location. The second link works with no issues. The first however brings me to the above error message. If I disable the Force Style on Prefix addon, the first link works. I enable it and again the error message above occurs if I click the first link.

So actually there are two issues. Duplicated threads in the recent thread widget if a thread is moved and the above error message. I have forwarded xfrocks to this post for the duplicated thread issue.

Edit: oops, I missed a line from the error message. Have added it now.

 

[Chris D]

Yeah, the duplicated thread issue occurs when a redirect is created. Redirects are created as new threads with their own thread ID so the recent threads block shouldn't pull these. It's either that or the widget cache. I'm sure xfrocks will fix this up.

I will do some testing with regards to this add-on and thread redirects, though.

 

[Chris D]

Chris Deeming updated Force Style On Thread Prefix with a new update entry:

Fixes "undefined index" exception

An "undefined index 'thread'" exception could occur on threads moved with a redirect in place.

This update resolves that issue.

Read the rest of this update entry...

 

[Luxus]

I accidently deleted my text I was going to post
Anyway, thanks for the explanation. The update solves this issue. Many thanks

 

[DRE]

Addon Installer Error. Does it have something to do with my new host?


Server Error

Unknown error within ZIP Archive

1. Zend_Filter_Compress_Zip->decompress() in Zend/Filter/Decompress.php at line 47
2. Zend_Filter_Decompress->filter() in AddOnInstaller/Model/AddOn.php at line 29
3. AddOnInstaller_Model_AddOn->extractZip() in AddOnInstaller/ControllerAdmin/AddOn.php at line 57
4. AddOnInstaller_ControllerAdmin_AddOn->actionInstallUpgrade() in XenForo/FrontController.php at line 310
5. XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 132
6. XenForo_FrontController->run() in /var/www/vhosts/user/httpdocs/admin.php at line 13

 

[Chris D]

You would have to ask your new host!

 

[MirrorMan]

I think I have found another bug while playing with a few ideas.

To quote your overview:

The override style set on the Thread Prefix will ignore any override style set on the Node.

While this is true, the Node's override style is ignored even if the Thread Prefix does not have an override style selected. This means that the member will see the thread in whichever style they have selected instead of the style we want them to see in that particular Node. Any threads without prefixes are displayed with the Node's override style so that's not the issue. It appears that adding a prefix switches off the Node's override style without checking whether the prefix will force one or not.

If I switch off the add-on everything works as expected.

 

[Chris D]

Chris Deeming updated Force Style On Thread Prefix with a new update entry:

Bug fix

Fixes the bug described here:

http://xenforo.com/community/threads/force-style-on-thread-prefix.42840/#post-628422

Read the rest of this update entry...

 

[MirrorMan]

That's fixed it

Thanks for such a quick update!

 

[fly]

What are the chances this could be updated to XF2?

 

[electrogypsy]

What are the chances this could be updated to XF2?

I'm curious about the same thing, or maybe finding a similar addon for xf2.

 

[Chris D]

I’m sure someone asked me if they could port the code to XF2.

I said, yes, of course. I can’t remember who it was.