Force Style On Thread Prefix

Force Style On Thread Prefix 1.0.2

No permission to download
Overview Updates (2) Reviews (2) History Discussion
ArnyVee

ArnyVee

Well-known member
Very cool Chris! I'm going to look into this at a later date as I have some ideas for this :)

Thanks for allowing it to be shared Luxus! :D
 
L

Luxus

Well-known member
I have possibly found a bug in this addon. Although it could be related to Widget Framework.
Code: 
Undefined property: XenForo_ControllerResponse_Redirect::$params
 
    XenForo_Application::handlePhpError() in ForceStyleOnPrefix/ControllerPublic/Thread.php at line 9
    ForceStyleOnPrefix_ControllerPublic_Thread->actionIndex() in XenForo/FrontController.php at line 310
    XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 132
    XenForo_FrontController->run() in C:/Winginx/home/xen/index.php at line 13
This error occured as follows:

I have the recent threads widget of widget framework. It shows recent X threads. One of the threads has a prefix. I moved this thread to a forum with no prefixes. Thread has been moved successfully and of course the prefix disappeared. But now the thread is displayed twice in the recent threads widget. The first is the thread from the original location and the second is the thread moved to a different location. The second link works with no issues. The first however brings me to the above error message. If I disable the Force Style on Prefix addon, the first link works. I enable it and again the error message above occurs if I click the first link.

So actually there are two issues. Duplicated threads in the recent thread widget if a thread is moved and the above error message. I have forwarded xfrocks to this post for the duplicated thread issue.

Edit: oops, I missed a line from the error message. Have added it now.
 
Chris D

Chris D

XenForo developer
Staff member
Yeah, the duplicated thread issue occurs when a redirect is created. Redirects are created as new threads with their own thread ID so the recent threads block shouldn't pull these. It's either that or the widget cache. I'm sure xfrocks will fix this up.

I will do some testing with regards to this add-on and thread redirects, though.
 
L

Luxus

Well-known member
I accidently deleted my text I was going to post :mad:
Anyway, thanks for the explanation. The update solves this issue. Many thanks (y)
 
DRE

DRE

Well-known member
Addon Installer Error. Does it have something to do with my new host?


Server Error

Unknown error within ZIP Archive
  1. Zend_Filter_Compress_Zip->decompress() in Zend/Filter/Decompress.php at line 47
  2. Zend_Filter_Decompress->filter() in AddOnInstaller/Model/AddOn.php at line 29
  3. AddOnInstaller_Model_AddOn->extractZip() in AddOnInstaller/ControllerAdmin/AddOn.php at line 57
  4. AddOnInstaller_ControllerAdmin_AddOn->actionInstallUpgrade() in XenForo/FrontController.php at line 310
  5. XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 132
  6. XenForo_FrontController->run() in /var/www/vhosts/user/httpdocs/admin.php at line 13
 
MirrorMan

MirrorMan

Member
I think I have found another bug while playing with a few ideas.

To quote your overview:
The override style set on the Thread Prefix will ignore any override style set on the Node.
Click to expand...
While this is true, the Node's override style is ignored even if the Thread Prefix does not have an override style selected. This means that the member will see the thread in whichever style they have selected instead of the style we want them to see in that particular Node. Any threads without prefixes are displayed with the Node's override style so that's not the issue. It appears that adding a prefix switches off the Node's override style without checking whether the prefix will force one or not.

If I switch off the add-on everything works as expected.
 
Chris D

Chris D

XenForo developer
Staff member
I’m sure someone asked me if they could port the code to XF2.

I said, yes, of course. I can’t remember who it was.
 
You must log in or register to reply here.
Top