XF 2.3 Font awesome icon not working properly

[FoxSecrets]

I am building an add-on and need to show a font awesome icon.

I've put an IF condition to insert the icon, however, the icon code made for 2.3 version brakes the code when running in XF 2.2, and do not show the icon in XF 2.3.

How can I have an icon in both XF versions?

<xf:if is="{{$xf.versionId}} < '2030000'">
    <i class="fal fa-globe"></i>
<xf:else />
    <xf:fa icon="fa-light fa-globe" aria-hidden="true">
</xf:if>

 

[bzcomputers]

have you tried...

<xf:if is="$xf.versionId < 2030000">

 

[FoxSecrets]

have you tried...

<xf:if is="$xf.versionId < 2030000">

The problem isn't the IF condition, this is ok...
The real problem is the icon code for XF 2.3 version...

<xf:fa icon="fa-light fa-globe" aria-hidden="true">

This code brakes the add-on when running in XF 2.2, and do not show the icon in XF 2.3.

 

[bzcomputers]

Gotcha.

The simplest solution would be to eliminate the conditional altogether and just use...

<i class="fal fa-globe" data-xf-init="icon"></i>

This should work fine in both 2.2 and 2.3+.

 

[FoxSecrets]

Gotcha.

The simplest solution would be to eliminate the conditional altogether and just use...

<i class="fal fa-globe" data-xf-init="icon"></i>

This should work fine in both 2.2 and 2.3+.

Didn't work. Have no idea why. It doesn't appear in XF2.3.

 

[bzcomputers]

I use that exact format all the time in custom PHP code for XF 2.3 without issue.

Do you have a sample PHP code block or a testing page I could see the issue in action?

 

[FoxSecrets]

Nothing special, it's just the IF condition I posted initially. The code you provided works fine in XF 2.2 version.

Well, I got it working in XF 2.3, but I had to insert the font awesome script in the head tag and set the icon as solid , like <i class="fas fa-globe" ></I>

I thought it was supposed to work without the script... Shouldn't be integrated into XF 2.3?

 

[Kirby]

<xf:fa icon="fal fa-globe" aria-hidden="true" />

If possible (only works where XF template syntax can be used) this is the recommended way to use FA and works just fine with XF 2.2 and 2.3, no need to tinker with <xf:if> or JS at all.

 

[FoxSecrets]

I still didn't get this working. I believe is something in the development.

Am developing in XF 2.2, which the icon works fine and whatever I write, it shows in the page, however, after releasing the add-on from 2.2 and installing the file in 2.3, the changes do not appear, even the console log to track the code, it doesn't appear in 2.3. That means, I change the icon, save and release the file, but does not work in 2.3.

Is there any thing I am missing when running the 2.2 addon in 2.3?

 

[FoxSecrets]

I fixed the issue.

I now built the add-on in a 2.3 environment (instead of 2.2) and it worked.

Probably the building algorithm is different.