Finder::setDefaultOrder vs Finder::order() differences in multi-column ordering

[Xon]

Affected version

2.2.5

Suppose a new multi-column sort order is added by extending in \XF\Repository with;

public function getDefaultThreadListSortOptions($forAdminConfig): array
{
    $options = parent::getDefaultThreadListSortOptions($forAdminConfig);

    $options['MyNewColumnAlias'] = [
        ['MyNewColumn'],
        ['last_post_date'],
    ];

    return $options;
}

When set as an explicit forum filter, this results in the following code;

$finder->setOrder([
 ['MyNewColumn'],
 ['last_post_date'],
], 'desc');

The resulting SQL contains; order by MyNewColumn desc, last_post_date desc

When set as the forum default without an explicit filter;

$finder->setDefaultOrder([
 ['MyNewColumn'],
 ['last_post_date'],
], 'desc');

The resulting SQL contains; order by MyNewColumn asc, last_post_date asc.

The problem is setDefaultOrder() calls standardizeOrderingValue() while order() does not, and standardizeOrderingValue() is inconsistent with order() in how a default direction applied to the sorting order.

 

[Xon]

This still applies to XF2.3.6

order is probably the correct definition, but standardizeOrderingValue probably shouldn't be repeating so much behavior but with different validation