XF 1.1 Finally Went Live... Now Memory Issues

[JRW-910]

I just moved an existing vB forum over to xF and I have having some issues:

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 71 bytes) in /home/site/public_html/library/Zend/Db/Statement/Mysqli.php on line 295

Any ideas?

-JRW

 

[JRW-910]

@JRW-910

Well that was a pain in the ***. After some very tedious debugging I isolated the source of the memory usage. You have 80,000 items in moderation. When an admin or mod logs in it counts all of those records.

For you I suggest one of these two things:

http://xenforo.com/community/resources/approve-all-moderated-posts-queries.373/
http://xenforo.com/community/resources/soft-delete-all-moderated-posts-queries.371/

That will clear out the queue and fix the memory problem.

I just approved them for now... thanks... this worked perfectly...

-JRW

 

[Jake Bunce]

I would delete since you don't know what they are. Otherwise you might approve stuff you don't want. The soft delete would allow you to review them later.

 

[MGSteve]

Nice work Jake and one to remember for later if we hear of similar issues.

 

[Ingenious]

Yes, good work Jake!

 

[Adam Howard]

@JRW-910

Well that was a pain in the ***. After some very tedious debugging I isolated the source of the memory usage. You have 80,000 items in moderation. When an admin or mod logs in it counts all of those records.

For you I suggest one of these two things:

http://xenforo.com/community/resources/approve-all-moderated-posts-queries.373/
http://xenforo.com/community/resources/soft-delete-all-moderated-posts-queries.371/

That will clear out the queue and fix the memory problem.

I'd call this a memory issue or a vulnerability.... It wouldn't take much for myself or someone to write bot that joined X site and just report every post.

Ever have one of those long thread such as "last one to post wins" or "What are you doing today?" or "Random Chat" ...... Target one of those and you'd kill a site easily.

edit: Disregard. Provided someone is smart enough to have a time limit between post... This shouldn't be a concern.

 

[Rodrigo Farcas]

@JRW-910

Well that was a pain in the ***. After some very tedious debugging I isolated the source of the memory usage. You have 80,000 items in moderation. When an admin or mod logs in it counts all of those records.

For you I suggest one of these two things:

http://xenforo.com/community/resources/approve-all-moderated-posts-queries.373/
http://xenforo.com/community/resources/soft-delete-all-moderated-posts-queries.371/

That will clear out the queue and fix the memory problem.

Yes, but still, this should not "kill" the memory. An improvement can be made hopefully

 

[Jake Bunce]

It's already fixed in the next version (presumably 1.2):

http://xenforo.com/community/thread...eration-queue-can-lock-up-your-browser.24326/

 

[Mike]

This issue itself probably won't be fixed - this is the problem trying to get the count. If you can get the count, then it's fixed.

 

[CTXMedia]

I've seen this a number of times now with imports - the "soft deleted" items pushed into the moderation queue, but in such large volumes that XF crashes when trying to load them all at once.

Is the moderation queue being split into pages in 1.2?

 

[Rodrigo Farcas]

@JRW-910

Well that was a pain in the ***. After some very tedious debugging I isolated the source of the memory usage. You have 80,000 items in moderation. When an admin or mod logs in it counts all of those records.

For you I suggest one of these two things:

http://xenforo.com/community/resources/approve-all-moderated-posts-queries.373/
http://xenforo.com/community/resources/soft-delete-all-moderated-posts-queries.371/

That will clear out the queue and fix the memory problem.

Hello Jake!

What will be the query to hard-delete all moderated posts ?

Thank you!

 

[Jake Bunce]

Hello Jake!

What will be the query to hard-delete all moderated posts ?

Thank you!

The data spans multiple tables as well as the file system (attachments). I don't recommend trying to hard-delete with queries. Soft-delete is easier.

1.2 may have better options for this.

 

[Rodrigo Farcas]

The data spans multiple tables as well as the file system (attachments). I don't recommend trying to hard-delete with queries. Soft-delete is easier.

1.2 may have better options for this.

Yes, but still i don't want as an admin browsing forums with lots of soft-deleted.. can you help me get the hard-delete queries?

 

[Jake Bunce]

Yes, but still i don't want as an admin browsing forums with lots of soft-deleted

You could move those threads with a query:

UPDATE xf_thread
SET node_id = 2
WHERE discussion_state = 'deleted'

 

[Rodrigo Farcas]

You could move those threads with a query:

UPDATE xf_thread
SET node_id = 2
WHERE discussion_state = 'deleted'

Great!
That will move moderated posts and moderated threads? are they treated the same?

 

[Jake Bunce]

Great!
That will move moderated posts and moderated threads? are they treated the same?

It will move deleted threads only. Post can't be moved out of their threads.

To move moderated threads use this:

UPDATE xf_thread
SET node_id = 2
WHERE discussion_state = 'moderated'

 

[Deriel]

@JRW-910

Well that was a pain in the ***. After some very tedious debugging I isolated the source of the memory usage. You have 80,000 items in moderation. When an admin or mod logs in it counts all of those records.

For you I suggest one of these two things:

http://xenforo.com/community/resources/approve-all-moderated-posts-queries.373/
http://xenforo.com/community/resources/soft-delete-all-moderated-posts-queries.371/

That will clear out the queue and fix the memory problem.

I had the same problem - 23k items in the moderation queue. The same solution worked to me, many thanks