XF 1.3 favicon.ico 404 not found error

[rdn]

I can only re-produce this error on forums that enable Google Login.
http://www.webpagetest.org/result/140602_2H_S37/
http://www.webpagetest.org/result/140602_V9_S39/
http://www.webpagetest.org/result/140602_JZ_S3C/

I only tested the lost password page to minimize the content.
It doesn't happen on page without Google Login:
http://www.webpagetest.org/result/140602_GP_S36/

So this issue is something to do with Google Connect/Login?

 

[Mike]

I saw a 404 once in one of my actual requests related to the favicon, but it was coming from Google's servers.

It could be related to this line that you have added:

<link rel="shortcut icon" href="favicon.ico" pagespeed_lsc_url="https://www.phcorner.net/favicon.ico"/>

The request appearing on those tests would be indicative of how a browser would treat that URL if it didn't handle the base tag. That could be a legitimate error, but it's not evident what is causing the request as I can't see any sort of stack trace and I can't reproduce the issue with my own browser. Alternatively, it could be a quirk with the actual test bed.

 

[Carlos]

I hope the OP knows that he can add favicon.ico to the root and be done with it (ahem; nothing else to do).

 

[Mike]

That's unrelated to the issue being reported... (It already exists and that's not where the error is coming from.)

 

[Carlos]

That's unrelated to the issue being reported... (It already exists and that's not where the error is coming from.)

I read it again, then again, and I was going like "Ohh.. THAT!"

It's like... google's interfering with the favicon code. *embarrassed look*

 

[rdn]

It could be related to this line that you have added:

<link rel="shortcut icon" href="favicon.ico" pagespeed_lsc_url="https://www.phcorner.net/favicon.ico"/>

That code is modified automatically by ngx_pagespeed module.
xenmediagallery.com site one of the URL I tested still has an issue of favicon.ico not found but I know they are not using ngx_pagespeed.
@Chris D is this something to do with Live Update addon?

 

[Chris D]

Live Update does explicitly define the favicon.ico location in the template, yes.

 

[rdn]

Looks like a conflict with Live Update and Google Login ?

 

[Chris D]

Nothing to do with Live Update. The code added is perfectly valid.

 

[Mike]

That code is modified automatically by ngx_pagespeed module.

I wasn't referring to the modification from pagespeed. You're pulling "favicon.ico" and relying on the <base> tag to do the work for the browser to pull it from the correct location in the route (XF uses this approach in general). I'm not saying it's inherently wrong, but there may be clients that don't understand it and JS needs to be explicitly modified to handle things like <base> tags. Using "/favicon.ico" should eliminate that variable.