Fixed False positive from isPageCriteriaValid for controller match for matching controller (without an action)


Well-known member
Affected version
isPageCriteriaValid checks;

case 'controller':
   if (isset($criterion['data']['name']) && isset($criterion['data']['action']))

But in _matchController;
if (!empty($data['action']) && isset($params['action']))
   if (strtolower($params['action']) != strtolower($data['action']))
      return false;
(should just be !empty not need to check isset)

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.3).

Change log:
Ensure that the invalid notice criteria message isn't displayed if the page criteria controller action field is empty.
Any changes made as a result of this issue being resolved may not be rolled out here until later.