Fixed False array value used in XenResource_ModerationQueueHandler_Update

[xf_phantom]

Method XenResource_ModerationQueueHandler_Update::getVisibleModerationQueueEntriesForUser

The second foreach (line 26) is using $updates AS $updates instead of $updates AS $update


It won't throw an error because $update is defined while the first foreach

foreach ($updates AS $updates)
{
if (!isset($resources[$update['resource_id']]))
{
continue;
}

 

[Mike]

Cheers D, have fixed.

Why did PHPStorm not complain about that?!

 

[xf_phantom]

Cheers D, have fixed.

Why did PHPStorm not complain about that?!

it did!

 

[Mike]

Just yellow "maybe this is wrong", I need the red!

 

[xf_phantom]

there's also another complain which you should check (haven't tested it)

 

[xf_phantom]

Just yellow "maybe this is wrong", I need the red!

You should define your own rules..
Most of them are useless so i ignore them but there are also IMO many of the yellow ones which are worth to be red
But they only rock in combination with php code sniffer (and php mess)

 

[Alluidh]

@Mike
Is this fixed in the packages now or should it be fixed by hand?

 

[Mike]

Fixed by hand.